Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey does not fire when changing routes in ngRoute #270

Open
gentisaliu opened this issue Jun 22, 2017 · 1 comment
Open

Hotkey does not fire when changing routes in ngRoute #270

gentisaliu opened this issue Jun 22, 2017 · 1 comment

Comments

@gentisaliu
Copy link

Suppose I have two ngRoutes, route1 and route2, where route1 shows a list of companies and route2 displays details about that company.

In route2 I want hotkeys to work (Ctrl + Up ). When I first visit route2 for a company, the hotkey binding works. Then when I go back to route1 and select another company (even the same), the hotkey is no longer firing.

Is my configuration wrong or is this a bug?

Plunkr which reproduces the issue: http://plnkr.co/edit/wnpchyabeKGuciDJ6H5E?p=preview

@aramando aramando mentioned this issue Jun 27, 2017
@aramando
Copy link

@gentisaliu This is a bug, which I've fixed in the above PR. It's unlikely to get merged, though; @chieffancypants hasn't been responding for a long time. Feel free to use my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants