Merge pull request #313 from eigan/patch-1

codemasher · web-flow · commit 9eeb2f5845ed · 2025-09-19T14:54:25.000+02:00
Do not use AlphaNum when string contains comma
diff --git a/src/Data/AlphaNum.php b/src/Data/AlphaNum.php
@@ -36,7 +36,7 @@ public function getLengthInBits():int{
 	}
 
 	public static function validateString(string $string):bool{
-		return (bool)preg_match('/^[A-Z\d %$*+-.:\/]+$/', $string);
+		return (bool)preg_match('/^[A-Z\d %$*+\-.:\/]+$/', $string);
 	}
 
 	public function write(BitBuffer $bitBuffer, int $versionNumber):static{
diff --git a/tests/Data/AlphaNumTest.php b/tests/Data/AlphaNumTest.php
@@ -35,7 +35,7 @@ public static function stringValidateProvider():array{
 			['ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890 $%*+-./:', true],
 			['abc', false],
 			['ÄÖÜ', false],
-			[',', true],
+			[',', false],
 			['-', true],
 			['+', true],
 			['.', true],

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function getLengthInBits():int{`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public static function validateString(string $string):bool{`
`39`		`- return (bool)preg_match('/^[A-Z\d %$*+-.:\/]+$/', $string);`
	`39`	`+ return (bool)preg_match('/^[A-Z\d %$*+\-.:\/]+$/', $string);`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`public function write(BitBuffer $bitBuffer, int $versionNumber):static{`