From 4d9581a222fd50a57cb515ad78490eadfd64258e Mon Sep 17 00:00:00 2001 From: Daniel Rose Date: Thu, 9 Nov 2023 16:00:30 +0100 Subject: [PATCH 1/2] (vscode.install) 32-bit version not available anymore after 1.83 From https://code.visualstudio.com/docs/supporting/faq#_previous-release-versions: > Windows x86 32-bit versions are no longer actively supported after release 1.83 and could pose a security risk. --- automatic/vscode.install/README.md | 1 + automatic/vscode.install/tools/ChocolateyInstall.ps1 | 3 --- automatic/vscode.install/update.ps1 | 5 ----- automatic/vscode/vscode.nuspec | 1 + 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/automatic/vscode.install/README.md b/automatic/vscode.install/README.md index 5c534383e42..8198d42715c 100644 --- a/automatic/vscode.install/README.md +++ b/automatic/vscode.install/README.md @@ -24,6 +24,7 @@ Example: `choco install vscode.install --params "/NoDesktopIcon /DontAddToPath"` * The package uses default install options except that it adds context menu entries and Visual Studio Code isn't started after installation. * For disabling the auto-update functionality see the [Visual Studio Code Auto Update Deactivation package](https://chocolatey.org/packages/visualstudiocode-disableautoupdate). +* Version 1.83.1 is the last version which is available in 32-bit and 64-bit. All later versions are 64-bit only. * **If the package is out of date please check [Version History](#versionhistory) for the latest submitted version. If you have a question, please ask it in [Chocolatey Community Package Discussions](https://github.com/chocolatey-community/chocolatey-packages/discussions) or raise an issue on the [Chocolatey Community Packages Repository](https://github.com/chocolatey-community/chocolatey-packages/issues) if you have problems with the package. Disqus comments will generally not be responded to.** ![screenshot](https://cdn.jsdelivr.net/gh/chocolatey-community/chocolatey-coreteampackages@6dc510f16b69a2134e901f2576e991c462a18e9b/automatic/vscode/screenshot.png) diff --git a/automatic/vscode.install/tools/ChocolateyInstall.ps1 b/automatic/vscode.install/tools/ChocolateyInstall.ps1 index 62f56d8182c..757c456c6d5 100644 --- a/automatic/vscode.install/tools/ChocolateyInstall.ps1 +++ b/automatic/vscode.install/tools/ChocolateyInstall.ps1 @@ -16,13 +16,10 @@ Close-VSCode $packageArgs = @{ packageName = 'vscode.install' fileType = 'exe' - url = 'https://update.code.visualstudio.com/1.83.1/win32/stable' url64bit = 'https://update.code.visualstudio.com/1.83.1/win32-x64/stable' softwareName = "$softwareName" - checksum = '6b5830991395299b59d1d8f4ecb3a9d752ef64b9b39c5dd4be848851c87f3126' - checksumType = 'sha256' checksum64 = '4ce748cdd111d88e1b7990641912a0e55904709a2cc85a72895ee6d7aa1801fd' checksumType64 = 'sha256' diff --git a/automatic/vscode.install/update.ps1 b/automatic/vscode.install/update.ps1 index bbee48c809d..b32051fd42e 100644 --- a/automatic/vscode.install/update.ps1 +++ b/automatic/vscode.install/update.ps1 @@ -4,7 +4,6 @@ Import-Module "$PSScriptRoot\..\..\scripts\au_extensions.psm1" if ($MyInvocation.InvocationName -ne '.') { function global:au_BeforeUpdate { - $Latest.Checksum32 = Get-RemoteChecksum $Latest.URL32 $Latest.Checksum64 = Get-RemoteChecksum $Latest.URL64 } } @@ -13,9 +12,7 @@ function global:au_SearchReplace { @{ 'tools\chocolateyInstall.ps1' = @{ "(?i)(^\s*packageName\s*=\s*)('.*')" = "`$1'$($Latest.PackageName)'" - "(?i)(^\s*url\s*=\s*)('.*')" = "`$1'$($Latest.URL32)'" "(?i)(^\s*url64bit\s*=\s*)('.*')" = "`$1'$($Latest.URL64)'" - "(?i)(^\s*checksum\s*=\s*)('.*')" = "`$1'$($Latest.Checksum32)'" "(?i)(^\s*checksum64\s*=\s*)('.*')" = "`$1'$($Latest.Checksum64)'" "(?i)(^[$]version\s*=\s*)('.*')" = "`$1'$($Latest.RemoteVersion)'" } @@ -26,13 +23,11 @@ function global:au_GetLatest { $latestRelease = Get-GitHubRelease microsoft vscode $version = $latestRelease.tag_name # URLs are documented here: https://code.visualstudio.com/docs/supporting/faq#_previous-release-versions - $url32 = "https://update.code.visualstudio.com/$version/win32/stable" $url64 = "https://update.code.visualstudio.com/$version/win32-x64/stable" @{ Version = $version RemoteVersion = $version - URL32 = $url32 URL64 = $url64 } } diff --git a/automatic/vscode/vscode.nuspec b/automatic/vscode/vscode.nuspec index 8e2aad6f004..1396f3a1be5 100644 --- a/automatic/vscode/vscode.nuspec +++ b/automatic/vscode/vscode.nuspec @@ -39,6 +39,7 @@ Example: `choco install vscode --params "/NoDesktopIcon /DontAddToPath"` * The package uses default install options except that it adds context menu entries and Visual Studio Code isn't started after installation. * For disabling the auto-update functionality see the [Visual Studio Code Auto Update Deactivation package](https://chocolatey.org/packages/visualstudiocode-disableautoupdate). +* Version 1.83.1 is the last version which is available in 32-bit and 64-bit. All later versions are 64-bit only. * **If the package is out of date please check [Version History](#versionhistory) for the latest submitted version. If you have a question, please ask it in [Chocolatey Community Package Discussions](https://github.com/chocolatey-community/chocolatey-packages/discussions) or raise an issue on the [Chocolatey Community Packages Repository](https://github.com/chocolatey-community/chocolatey-packages/issues) if you have problems with the package. Disqus comments will generally not be responded to.** ![screenshot](https://cdn.jsdelivr.net/gh/chocolatey-community/chocolatey-coreteampackages@6dc510f16b69a2134e901f2576e991c462a18e9b/automatic/vscode/screenshot.png) From b22ebcc812304aebb3064c1b4e0cf6be2ce645a0 Mon Sep 17 00:00:00 2001 From: Daniel Rose Date: Thu, 9 Nov 2023 16:16:33 +0100 Subject: [PATCH 2/2] (vscode) fix install options documentation The documentation in vscode was missing options described in vscode.install. --- automatic/vscode.install/README.md | 4 ++-- automatic/vscode/vscode.nuspec | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/automatic/vscode.install/README.md b/automatic/vscode.install/README.md index 8198d42715c..d7d5eddda1e 100644 --- a/automatic/vscode.install/README.md +++ b/automatic/vscode.install/README.md @@ -14,8 +14,8 @@ Build and debug modern web and cloud applications. Code is free and available on * `/NoDesktopIcon` - Don't add a desktop icon. * `/NoQuicklaunchIcon` - Don't add an icon to the QuickLaunch area. * `/NoContextMenuFiles` - Don't add an _Open with Code_ entry to the context menu for files. -* `/NoContextMenuFolders` - Dont't add an _Open with Code_ entry to the context menu for folders. -* `/DontAssociateWithFiles` - Dont't associate Visual Studio Code with supported files. +* `/NoContextMenuFolders` - Don't add an _Open with Code_ entry to the context menu for folders. +* `/DontAssociateWithFiles` - Don't associate Visual Studio Code with supported files. * `/DontAddToPath` - Don't add Visual Studio Code to the system PATH. Example: `choco install vscode.install --params "/NoDesktopIcon /DontAddToPath"` diff --git a/automatic/vscode/vscode.nuspec b/automatic/vscode/vscode.nuspec index 1396f3a1be5..ec7288d15f7 100644 --- a/automatic/vscode/vscode.nuspec +++ b/automatic/vscode/vscode.nuspec @@ -30,7 +30,8 @@ * `/NoDesktopIcon` - Don't add a desktop icon. * `/NoQuicklaunchIcon` - Don't add an icon to the QuickLaunch area. * `/NoContextMenuFiles` - Don't add an _Open with Code_ entry to the context menu for files. -* `/NoContextMenuFolders` - Dont't add an _Open with Code_ entry to the context menu for folders. +* `/NoContextMenuFolders` - Don't add an _Open with Code_ entry to the context menu for folders. +* `/DontAssociateWithFiles` - Don't associate Visual Studio Code with supported files. * `/DontAddToPath` - Don't add Visual Studio Code to the system PATH. Example: `choco install vscode --params "/NoDesktopIcon /DontAddToPath"`