Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoUninstaller - Captures registry snapshot escaping quotes - unable to find path for uninstall #1540

Closed
externl opened this issue Apr 17, 2018 · 9 comments
Closed

AutoUninstaller - Captures registry snapshot escaping quotes - unable to find path for uninstall #1540

externl opened this issue Apr 17, 2018 · 9 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.10.11

Comments

@externl
Copy link

externl commented Apr 17, 2018 •
edited
Loading

What You Are Seeing?

git.install auto uninstaller can't find the git uninstaller even though it exists. The path seems to have bogus quotes.

 Skipping auto uninstaller - The uninstaller file no longer exists. ""C:\Program Files\Git\unins000.exe""

What is Expected?

The git uninstall should run and git should be uninstalled.

How Did You Get This To Happen? (Steps to Reproduce)

choco install git.install
choco uninstall git.install

Output Log

git.install v2.17.0
 Running auto uninstaller...
 Skipping auto uninstaller - The uninstaller file no longer exists. ""C:\Program Files\Git\unins000.exe""
 git.install has been successfully uninstalled.

However, the file actually exists.

C:\Windows\system32>dir "C:\Program Files\Git"
 Volume in drive C is Windows 10
 Volume Serial Number is 6EFD-B73A

 Directory of C:\Program Files\Git

04/17/2018  05:08 PM    <DIR>          .
04/17/2018  05:08 PM    <DIR>          ..
04/17/2018  05:07 PM    <DIR>          bin
04/17/2018  05:08 PM    <DIR>          cmd
04/17/2018  05:08 PM    <DIR>          dev
04/17/2018  05:08 PM    <DIR>          etc
04/03/2018  11:29 AM           148,248 git-bash.exe
04/03/2018  11:29 AM           147,224 git-cmd.exe
03/19/2018  10:17 AM            18,765 LICENSE.txt
04/17/2018  05:07 PM    <DIR>          mingw64
04/03/2018  11:38 AM           128,430 ReleaseNotes.html
04/17/2018  05:07 PM    <DIR>          tmp
04/17/2018  05:08 PM         1,085,186 unins000.dat
04/17/2018  05:07 PM         1,289,880 unins000.exe
04/17/2018  05:08 PM            22,795 unins000.msg
04/17/2018  05:08 PM    <DIR>          usr
               7 File(s)      2,840,528 bytes
               9 Dir(s)  160,067,874,816 bytes free
@ferventcoder
Copy link
Member

Full log please.

@ferventcoder
Copy link
Member

@gep13 do you think this might have something to do with our changes for 0.10.9 where we are converting values with escaping bad XML?

@ferventcoder
Copy link
Member

ferventcoder commented Apr 17, 2018 •
edited
Loading

#1534

@externl
Copy link
Author

externl commented Apr 18, 2018 •
edited
Loading

@ferventcoder Do you still require a full output of an uninstall?

@AdmiringWorm
Copy link
Member

@ferventcoder I was able to reproduce this on the choco environment with 0.10.10.

I added a gist with both install and uninstall log, as well as the detected registry xml (which I believe is the source of the problem here).

https://gist.github.com/AdmiringWorm/61e34d79306b81c7d8b60bffadf6d9cd

@AdmiringWorm
Copy link
Member

Basically it seems the detection is escaping quotes when it shouldn't.

@ferventcoder ferventcoder self-assigned this Apr 24, 2018
@ferventcoder ferventcoder added this to the 0.10.11 milestone Apr 24, 2018
@ferventcoder
Copy link
Member

We think this was caused by #1505.

@ferventcoder ferventcoder changed the title Auto uninstaller can't find git.install's uninstaller AutoUninstaller is capturing registry snapshop escaping quotes - so can't find for uninstall Apr 24, 2018
@AeliusSaionji
Copy link

This same thing is happening to me for just about every package using an auto uninstaller. Perhaps this is a red herring: I'm using JPN locale.

@ferventcoder ferventcoder changed the title AutoUninstaller is capturing registry snapshop escaping quotes - so can't find for uninstall AutoUninstaller is capturing registry snapshop escaping quotes - unable to find path for uninstall Apr 24, 2018
@ferventcoder
Copy link
Member

It's not that, it's happening likely for everyone - so we're bumping the priority of this up.

@ferventcoder ferventcoder changed the title AutoUninstaller is capturing registry snapshop escaping quotes - unable to find path for uninstall AutoUninstaller - Captures registry snapshot escaping quotes - unable to find path for uninstall May 4, 2018
ferventcoder added a commit that referenced this issue May 4, 2018
@ferventcoder
(GH-1540) Fix - AutoUninstaller can't find escaped quotes
dabcac8 
The change made for GH-1505 caused the registry information to escape a
little too well, so some of the quotes and apostrophes were being saved
as `&apos;` and `&quot;`. When it came time for automatic uninstaller
to remove the software that was found in the snapshot, it didn't know
how to work with those escaped double quotes and gave up very quickly.

To fix this, don't escape those two items, but handle any that may have
already had this adjustment.
ferventcoder added a commit that referenced this issue May 4, 2018
@ferventcoder
Merge branch 'stable'
0113db6 
* stable:
  (version) 0.10.11
  (doc) update release notes for 0.10.11
  (GH-1540) Fix - AutoUninstaller can't find escaped quotes
  (GH-1543) Fix - log format error on install location with GUID
  (GH-1500) Fix - Wrap Write-Host if used in setup
  (GH-991) Install - Modify profile if file exists & empty
  (GH-1443) Set original config before loop
  (maint) add a note for GH-1548
  (GH-1557) Upgrade 7z to 18.5
@mwallner mwallner mentioned this issue Mar 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.10.11
Development

No branches or pull requests
5 participants
@ferventcoder @gep13 @AdmiringWorm @externl @AeliusSaionji