Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the no7ip build steps from overall Chocolatey CLI build process #3591

Open
2 tasks done
gep13 opened this issue Dec 12, 2024 · 2 comments
Open
2 tasks done

Remove the no7ip build steps from overall Chocolatey CLI build process #3591

gep13 opened this issue Dec 12, 2024 · 2 comments

Comments

@gep13
Copy link
Member

gep13 commented Dec 12, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

While this is no longer a problem, there was an issue related to this, which was fixed in a previous release.

There is no longer a requirement for a version of Chocolatey CLI that doesn't contain the 7zip assemblies, and as such, we can simplify our overall build process by removing the tasks related to creating it.

Describe The Solution. Why is it needed?

  • The ReleaseOfficialNo7zip build configuration should be removed from the *.sln file
  • Usage of the ReleaseOfficialNo7zip build configuration should be removed from all *.csproj files
  • All mention of no7zip should be removed from the recipe.cake file, as the collection of files specifiically for the no7zip build will no longer be required
  • The Prepare-ChocolateyNo7zip-Package, Build-ChocolateyNo7zip, and Create-ChocolateyNo7zip-Package tasks should be removed from the recipe.cake file
  • The Chocolatey CLI Release Process should be updated to remove the steps associated with the No7zip build

Additional Context

None

Related Issues

This is a follow up to this issue:

@gep13
Copy link
Member Author

gep13 commented Dec 12, 2024

@vexx32 @AdmiringWorm @pauby do we agree that this is technically a breaking change, and it should wait until the next major release of Chocolatey CLI?

@AdmiringWorm
Copy link
Member

In terms of versioning, then no. I would not consider this a breaking change.

But we definitely would need to notify those affected by us not providing no7zip builds anymore before the next release of CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants