Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

ScriptsContainTooManyLines shouldn't count signature lines #183

Open
clairernovotny opened this issue Jul 19, 2018 · 1 comment
Open

ScriptsContainTooManyLines shouldn't count signature lines #183

clairernovotny opened this issue Jul 19, 2018 · 1 comment

Comments

@clairernovotny
Copy link

This warning/check should exclude the line-count added by signed scripts.

It's flagging a signed ps1 file as being too long.

https://github.com/chocolatey/package-validator/wiki/ScriptsContainTooManyLines

To repro, look at the ps1 in the NuGetPackageExplorer package; you'll see an example of a signed powershell script.

@gep13
Copy link
Member

gep13 commented Jul 19, 2018

@onovotny this is a good suggestion. I notice that this isn't causing you a "problem" just now, as this is just a guideline, rather than a requirement, but this definitely makes sense to look at.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants