You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is Your Feature Request Related To A Problem? Please describe.
The AbstractLicenseValidator.cs file contains a number of messages that are similar. Additionally there are some places where we're using the wrong variable (licenseType instead of License).
Describe The Solution. Why is it needed?
These should likely be abstracted into a constant variable for the message with formatting to insert the actual issue.
Additional Context.
Some examples:
if(date==null){Log.WarnFormat("[Licensing] Could not find expiration in license:\r\n{0}",License);returnfalse;}// snipif(licenseType==null){Log.WarnFormat("[Licensing] Could not find license type in {0}",licenseType);returnfalse;}
In this section, the message could be a refactored something like:
conststringWARNING_MESSAGE="[Licensing] Could not find {0} in license\r\n{1}";// snipif(date==null){Log.WarnFormat(WARNING_MESSAGE,"expiration",License);returnfalse;}// snipif(licenseType==null){Log.WarnFormat(WARNING_MESSAGE,"license type",License);// Note that licenseType was changed here as it's not actually what was intended.returnfalse;}
Related Issues
Discovered some of this while working on 18, but not related to 18 in any other way.
The text was updated successfully, but these errors were encountered:
Is Your Feature Request Related To A Problem? Please describe.
The
AbstractLicenseValidator.cs
file contains a number of messages that are similar. Additionally there are some places where we're using the wrong variable (licenseType
instead ofLicense
).Describe The Solution. Why is it needed?
These should likely be abstracted into a constant variable for the message with formatting to insert the actual issue.
Additional Context.
Some examples:
In this section, the message could be a refactored something like:
Related Issues
Discovered some of this while working on 18, but not related to 18 in any other way.
The text was updated successfully, but these errors were encountered: