Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Wrong specs in Implied and Reif constraints/propagators #1087

Open
363734 opened this issue Feb 22, 2024 · 0 comments
Open
Assignees
Labels

Comments

@363734
Copy link

363734 commented Feb 22, 2024

Hi,

When reading the code about implied and reification constraints, I noticed there are a few specifications issues (probably copy-paste related).

Both constraints share the same spec
image
image
Which is correct for Reification but not true for Implication.
In addition, they both use (in their constructor) the constraint name 'ConstraintsName.REIFICATIONCONSTRAINT' which may be correct if you use it as a category, but not if you use the name as the name of the actual constraint.

On the propagator side, they also share the same spec
image
image
Which is correct for Implication but not correct for Reification

Kind regards,
Hélène

@363734 363734 added the bug label Feb 22, 2024
@cprudhom cprudhom self-assigned this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants