We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The recommended way for plugins to "collaborate" with each other is to set a name: https://docs.pytest.org/en/7.1.x/how-to/writing_plugins.html#accessing-another-plugin-by-name
A name is currently set for the "wrapper" plugin, but not for the sub plugins that actually "do the work": https://github.com/chrisguidry/pytest-opentelemetry/blob/main/src/pytest_opentelemetry/plugin.py#L31 So the instance of OpenTelemetryPlugin that is registered ends up with an auto-generated name like 139984798453776. Setting a name when registering would more easily allow the plugin to be accessed by config.pluginmanager.get_plugin.
OpenTelemetryPlugin
139984798453776
config.pluginmanager.get_plugin
(FWIW my motivating internal use case is an idiosyncratic way of propagating trace ids.)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The recommended way for plugins to "collaborate" with each other is to set a name: https://docs.pytest.org/en/7.1.x/how-to/writing_plugins.html#accessing-another-plugin-by-name
A name is currently set for the "wrapper" plugin, but not for the sub plugins that actually "do the work": https://github.com/chrisguidry/pytest-opentelemetry/blob/main/src/pytest_opentelemetry/plugin.py#L31 So the instance of
OpenTelemetryPluginthat is registered ends up with an auto-generated name like139984798453776. Setting a name when registering would more easily allow the plugin to be accessed byconfig.pluginmanager.get_plugin.(FWIW my motivating internal use case is an idiosyncratic way of propagating trace ids.)
The text was updated successfully, but these errors were encountered: