Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price is not a relation and cannot select_related #112

Closed
wants to merge 7 commits into from

Conversation

nakato
Copy link
Contributor

@nakato nakato commented Apr 5, 2017

This field is ignored in 1.9, however in 1.10+ it is an error.
As this is a no-op in 1.9, removal keeps functionality while
extending compatability going forward.

For full details please see Django Ticket 10414 at:
https://code.djangoproject.com/ticket/10414

This field is ignored in 1.9, however in 1.10+ it is an error.
As this is a no-op in 1.9, removal keeps functionality while
extending compatability going forward.

For full details please see Django Ticket 10414 at:
https://code.djangoproject.com/ticket/10414
We probably want to see a whole bunch of errors collected in errors
anyways.  That should get converted to a string uppon being raised, so
pass errors directly.
There are a number of attempts to use Deci in ints, which won't work in
2.7 or 3.x, we fix that.

Description doesn't exist in symposion.  So that fails our tests pretty
hard.  Switch that to Private Abstract.  It's clear these tests have not
been run in a very long time.  So both failures and especially passes
need to be taken with salt.
This makes it possible to add a ' *' required notifier to labels without
needing a bunch of custom form code in templates.
@chrisjrn
Copy link
Owner

OK. I'm going to merge a bunch of this, but not all of it -- particularly, the Python 3 changes break compatibility with Python 2; compatibility can be maintained with six, and I'd like to keep that compatibility for the time being. https://pythonhosted.org/six/

@chrisjrn
Copy link
Owner

(Sorry for taking so long to get to this)

@chrisjrn
Copy link
Owner

FYI: The tests are kept up-to-date on registrasion, and provide 98% coverage over the business logic. They just target trunk symposion and not the lca2017 branch. As such, your test changes break the tests.

I'll see what I can do about making the tests run independently of proposal model changes, which is the correct fix in this case

@chrisjrn
Copy link
Owner

Created issue #116 to address tests breaking when proposal models change.

@chrisjrn
Copy link
Owner

Created issue #117 to deal with places where six should be used to bridge compatibility changes.

@chrisjrn
Copy link
Owner

#118 Replaces this pull request.

@chrisjrn chrisjrn closed this May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants