-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Price is not a relation and cannot select_related #112
Conversation
This field is ignored in 1.9, however in 1.10+ it is an error. As this is a no-op in 1.9, removal keeps functionality while extending compatability going forward. For full details please see Django Ticket 10414 at: https://code.djangoproject.com/ticket/10414
We probably want to see a whole bunch of errors collected in errors anyways. That should get converted to a string uppon being raised, so pass errors directly.
There are a number of attempts to use Deci in ints, which won't work in 2.7 or 3.x, we fix that. Description doesn't exist in symposion. So that fails our tests pretty hard. Switch that to Private Abstract. It's clear these tests have not been run in a very long time. So both failures and especially passes need to be taken with salt.
This makes it possible to add a ' *' required notifier to labels without needing a bunch of custom form code in templates.
OK. I'm going to merge a bunch of this, but not all of it -- particularly, the Python 3 changes break compatibility with Python 2; compatibility can be maintained with |
(Sorry for taking so long to get to this) |
FYI: The tests are kept up-to-date on I'll see what I can do about making the tests run independently of proposal model changes, which is the correct fix in this case |
Created issue #116 to address tests breaking when proposal models change. |
Created issue #117 to deal with places where |
#118 Replaces this pull request. |
This field is ignored in 1.9, however in 1.10+ it is an error.
As this is a no-op in 1.9, removal keeps functionality while
extending compatability going forward.
For full details please see Django Ticket 10414 at:
https://code.djangoproject.com/ticket/10414