-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot access disposed object #9
Comments
@alexrainman Ran into the issue as well and verified your changes fix it, thanks! |
@DennisWelu the only cons this carousel has that it loads all the pages on startup and that is really slow in Android. I was working on one implementation myself https://github.com/alexrainman/CarouselView but Xamarin came with their own on version 2.2-pre-release and i have been working close with them helping to make it work as expected. It's close the be released. |
I'm glad you said something! I was just contemplating the way in which I was going to add virtualization to it... I'll check out the pre-release instead. Thanks again! |
Yeah, the version that Xamarin is working on might be better suited -- especially concerning virtualization. My intention was to handle those concerns over time, but just never did. Thanks for the feedback :) |
Chris, i discovered and issue with your implementation and a way to fix it. Sometimes the Renderer is collected when you close the screen, then, when you open it again and you try to swipe, it crash because Element is null.
The fix?
Android renderer:
iOS renderer:
Thanks for sharing this.
The text was updated successfully, but these errors were encountered: