Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential issue: dependency conflicts #113

Open
christabor opened this issue May 15, 2017 · 0 comments
Open

potential issue: dependency conflicts #113

christabor opened this issue May 15, 2017 · 0 comments

Comments

@christabor
Copy link
Owner

christabor commented May 15, 2017

One thing that hasn't yet come up, but most certainly will with the nature of having many different libraries all abstracted into one configuration, is the notion of dependency management and conflicts.

While there is a way to manage dependencies across charts, it assumes they always work with whatever version is specified in the settings.

While this is an ideal scenario, it is not likely to be the case forever. A particular example this comes up for is the change from d3 to d3.v4 - a fairly drastic api change that may break many libraries that have not made the jump yet. Also, ones that have, now have to have their versions pinned backwards in order to work w/ the rest.

A few options:

  1. Multiple copies of a file loaded, for different versions (this likely creates a ton of bloat and potential namespace conflicts.)
  2. Ignore ones that aren't up to snuff - e.g. manually testing and just filtering out those that don't stay up-to-date
  3. Let the user choose (this kind of makes the idea of abstracting over this junk less useful though)

At this point in time, I'm inclined to pick 2, as it allows best code quality, no extra code, and really no change outside of more testing that needs to be done per version (which is somewhat necessary anyway).

I'm leaving it up here for now as it hasn't explicitly come up, but would be nice to have thought through to some extent when it eventually does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant