Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scriptnode] Copy/Pasting Nodes Is Broken #546

Open
aaronventure opened this issue Jun 21, 2024 · 0 comments
Open

[Scriptnode] Copy/Pasting Nodes Is Broken #546

aaronventure opened this issue Jun 21, 2024 · 0 comments

Comments

@aaronventure
Copy link

When you copy a node, or import a snippet from the clipboard, HISE will:

  • paste the nodes with the exact same ID
  • apply the connections from the clipboard based on ID,
    This breaks the core ScriptNode functionality where each parameter can only be modulated by one cable at a time.
    copy paste scriptnode

What should happen is:

  • HISE should check what the new IDs will be for the pasted nodes
  • change internal (within the copied nodes) connections so that they refer to the new IDs
  • keep any incoming connections from the outside, e.g. from the main parameters or other nodes
  • break any outgoing connections that go beyond the copy scope

The lack of proper implementation of this has some severe effects on the workflow for complicated networks:

  • it's impossible to duplicate more complex modchains, effectively having you go through the entire setup any time you need a copy
  • if you already developed a modchain within the network, but it grew to be too big, it's not possible to "move it to a separate file" like you can do with code in the code editor, so that you can then reimport it as a project node, because the connections will not copy over properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant