Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings in console of production #14

Closed
SashaRudolf opened this issue Jul 11, 2016 · 6 comments
Closed

Warnings in console of production #14

SashaRudolf opened this issue Jul 11, 2016 · 6 comments

Comments

@SashaRudolf
Copy link

I have a series of errors coming from some padding on a span, and some other minor warnings. However, I am fine with those styles not being rendered.

Could we add a config variable that would disable the warnings in production?

@Roilan
Copy link
Collaborator

Roilan commented Jul 11, 2016

@SashaRudolf Yes, you have a good point. We run into similar issues when running it in production and clogs up our logs. How do you feel about just checking for the production env variable? Thoughts @chromakode

@chromakode
Copy link
Owner

Yeah checking NODE_ENV is a good idea!

@Roilan
Copy link
Collaborator

Roilan commented Jul 12, 2016

I'll see if I have some time this week to make the PR.

@chromakode
Copy link
Owner

It was supposed to be possible to disable these with something like:

ReactHTMLEmail.configStyleValidator({
  strict: false,
  warn: process.NODE_ENV === 'production',
})

However it appears that there is a bug where the value of warn isn't taken into consideration. We should probably change the defaults to above as well.

@SashaRudolf
Copy link
Author

@Roilan @chromakode Sounds awesome, anyone had any time to work on this?

chromakode added a commit that referenced this issue Jul 19, 2016
@chromakode
Copy link
Owner

Fixed in v1.1.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants