Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a number for width and height doesn't give us responsive images #61

Open
nanomosfet opened this issue May 17, 2018 · 0 comments
Open

Comments

@nanomosfet
Copy link

Using a number for the width and height props forces you to know your image before hand.

If you supplied a string and then just passed it to the styles for the Image component it should render correctly even if you do '50%'. If I pass in styles from the Image component it even works but it gives a warning for prop types and it says you shouldn't assign width and height to div elements.

If you think its a good idea to make a change I can give it a go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant