You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this is a good idea in principle, but in practice ESLint and Prettier are huge dependencies. npm install eslint prettier currently adds 1245 files across 87 packages. From my experience trying to use them on other projects, they're quite likely to get outdated and eventually be marked with a security vulnerability.
I think you make a good case about catching accidental compat issues, but I'd advocate for something simple like maybe a self-contained CI job rather than turning this into a package-based project. (Although @engedy may certainly want to take on more complexity to provide wider browser compat.)
What about adding rules to the repo for Prettier code formatter and ESLint code analyzer?
This should significantly improve the contributor experience.
E.g. I've found that current code uses async / await syntax for Idle Detection API test (1, 2). This is the only place in the code where it is used.
The problem is that permission.site can be used for checking permissions in old browsers that don't support async / await syntax.
Adding
disable-async-await
ESLint rule could solve this problem.The text was updated successfully, but these errors were encountered: