diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e0f67013..e7ccfc14 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,49 +12,90 @@ concurrency: cancel-in-progress: true jobs: + lint: + name: Lint + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v3 + + - uses: pnpm/action-setup@v2.2.4 + with: + version: 8 + + - uses: actions/setup-node@v3 + with: + node-version: 16.x + cache: pnpm + + - name: 'Install dependencies' + run: pnpm install --frozen-lockfile + + - name: Lint + run: pnpm --filter ember-basic-dropdown lint + test: name: "Tests" runs-on: ubuntu-latest + needs: lint steps: - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + + - uses: pnpm/action-setup@v2.2.4 + with: + version: 8 + + - name: Install Node + uses: actions/setup-node@v3 with: - node-version: 16 - cache: npm + node-version: 16.x + cache: pnpm + - name: Install Dependencies - run: npm ci - - name: Lint - run: npm run lint + run: pnpm install --frozen-lockfile + - name: Run Tests - run: npm run test + run: pnpm --filter test-app test:ember floating: name: "Floating Dependencies" runs-on: ubuntu-latest + needs: lint steps: - uses: actions/checkout@v3 + + - uses: pnpm/action-setup@v2.2.4 + with: + version: 8 + - uses: actions/setup-node@v3 with: - node-version: 16 - cache: npm + node-version: 16.x + cache: pnpm + - name: Install Dependencies - run: npm ci + run: pnpm install --frozen-lockfile + - name: Run Tests - run: npm run test + run: pnpm --filter test-app test:ember try-scenarios: name: ${{ matrix.try-scenario }} runs-on: ubuntu-latest - needs: 'test' + continue-on-error: true + needs: test strategy: fail-fast: false matrix: try-scenario: + - ember-lts-3.28 + - ember-lts-4.4 - ember-lts-4.8 - ember-lts-4.12 + - ember-5.4 - ember-release - ember-beta - ember-canary @@ -63,12 +104,21 @@ jobs: steps: - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + + - uses: pnpm/action-setup@v2.2.4 + with: + version: 8 + + - name: Install Node + uses: actions/setup-node@v3 with: - node-version: 16 - cache: npm + node-version: 16.x + cache: pnpm + - name: Install Dependencies - run: npm ci + run: pnpm install --frozen-lockfile + - name: Run Tests - run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }} - working-directory: test-app + env: + EMBER_TRY_SCENARIO: ${{ matrix.try-scenario }} + run: pnpm --filter test-app test:ember-try $EMBER_TRY_SCENARIO diff --git a/.github/workflows/push-dist.yml b/.github/workflows/push-dist.yml deleted file mode 100644 index d946574a..00000000 --- a/.github/workflows/push-dist.yml +++ /dev/null @@ -1,28 +0,0 @@ -# Because this library needs to be built, -# we can't easily point package.json files at the git repo for easy cross-repo testing. -# -# This workflow brings back that capability by placing the compiled assets on a "dist" branch -# (configurable via the "branch" option below) -name: Push dist - -on: - push: - branches: - - main - - master - -jobs: - push-dist: - name: Push dist - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - name: Install Node - uses: actions/setup-node@v3 - with: - cache: 'npm' - - uses: kategengler/put-built-npm-package-contents-on-branch@v2.0.0 - with: - branch: dist - token: ${{ secrets.GITHUB_TOKEN }} - working-directory: ember-basic-dropdown diff --git a/test-app/tests/integration/components/basic-dropdown-test.js b/test-app/tests/integration/components/basic-dropdown-test.js index 26ce7a0c..61732cb7 100644 --- a/test-app/tests/integration/components/basic-dropdown-test.js +++ b/test-app/tests/integration/components/basic-dropdown-test.js @@ -922,6 +922,7 @@ module('Integration | Component | basic-dropdown', function (hooks) { `); + //open the nested dropdown await click('.ember-basic-dropdown-trigger.parent'); assert.dom('.body-parent').exists('the parent dropdown is rendered');