Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of unittest in favor of pytest #464

Closed
SamWitty opened this issue Jan 20, 2024 · 0 comments · Fixed by #465
Closed

Remove usage of unittest in favor of pytest #464

SamWitty opened this issue Jan 20, 2024 · 0 comments · Fixed by #465
Assignees
Labels

Comments

@SamWitty
Copy link
Contributor

In PRs #456 and #457 three additional test files were added to the test suite using the unittest python testing library. To maintain consistency with the existing tests, these tests should be removed in favor of pytest, which is used in the remainder of the repository. These new tests pass as pytest is compatible with tests written in unittest, but maintaining a single testing style will be easier to maintain as the scope of PyCIEMSS grows.

In addition, the additional testing introduced in #456 and #457 should be moved into the existing test_interfaces.py file using the existing test fixtures in fixtures.py. At present, the new tests introduce manual filepaths that are isolated from this "gold standard" collection of models in a way that will be difficult to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants