Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling and Intervening on Constant Parameters #598

Closed
Tom-Szendrey opened this issue Aug 16, 2024 · 1 comment
Closed

Sampling and Intervening on Constant Parameters #598

Tom-Szendrey opened this issue Aug 16, 2024 · 1 comment

Comments

@Tom-Szendrey
Copy link

When running a sample call on a model that has a constant parameter, I am unable to include an intervention on that parameter.
Specifically I am running into this: https://github.com/ciemss/pyciemss/blob/main/pyciemss/integration_utils/result_processing.py#L374

I suspect it is because when I run a sample call with a model that has a constant parameter this constant parameter is not in the df that is being passed back.

Looking at one of your test folders I can see that the Out[4] here does not contain these constant parameters while it does contain the parameters that have distributions
https://github.com/ciemss/pyciemss/blob/main/docs/source/interfaces.ipynb
https://github.com/DARPA-ASKEM/simulation-integration/blob/main/data/models/SEIRHD_NPI_Type1_petrinet.json#L260-L273

An example of a missing parameter in this Out[4] would be
persistent_beta_s_param

This would presumably prevent us from having an intervention on this beta_s

@Tom-Szendrey
Copy link
Author

Already resolved
#597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant