Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm unit tests pass with new version of MIRA #611

Open
djinnome opened this issue Sep 13, 2024 · 1 comment · May be fixed by #616
Open

Confirm unit tests pass with new version of MIRA #611

djinnome opened this issue Sep 13, 2024 · 1 comment · May be fixed by #616
Assignees

Comments

@djinnome
Copy link
Contributor

From Tenzin:

The Northeastern team has been working on updating Pydantic 1 to Pydantic 2 in MIRA and currently all our unit tests are passing. We just want to make sure that updating to Pydantic 2 won't break anything downstream that relies on MIRA. We are also curious on how Uncharted (specifically the notebook section for model operators in Terarium) use MIRA?

And @liunelson :

Could you confirm with the CIEMSS team that this update is ok for them too?

gyorilab/mira#360

@SamWitty
Copy link
Contributor

@djinnome. Feel free to create a PR that pins the MIRA version to the bleeding edge. Our CI will run tests and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants