New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support custom lifecycle implementation #39

Open

Wangyiwei-So opened this issue Feb 12, 2025 · 0 comments

Wangyiwei-So commented Feb 12, 2025

https://vscode.dev/github/cilium/hive/blob/main/hive.go#L133-L135

now:

func NewWithOptions(opts Options, cells ...cell.Cell) *Hive {
	h := &Hive{
		lifecycle: &cell.DefaultLifecycle{
			LogThreshold: opts.LogThreshold,
		},
	}
...
}

want:

func NewWithOptions(opts Options, cells ...cell.Cell) *Hive {
	h := &Hive{
		lifecycle: opt.lifecycle
	}
        if h.lifecycle==nil{
               lifecycle=&cell.DefaultLifecycle{
			LogThreshold: opts.LogThreshold,
		},
        }
...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment