Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request lib with something different in hubble-ui #145

Closed
geakstr opened this issue Feb 26, 2020 · 3 comments
Closed

Replace request lib with something different in hubble-ui #145

geakstr opened this issue Feb 26, 2020 · 3 comments
Assignees
Labels
🖥 area/ui This impacts the Hubble UI

Comments

@geakstr
Copy link
Collaborator

geakstr commented Feb 26, 2020

Pull request with patch cilium/hubble-ui#8
Issue with request dep request/request#3274

@rolinh
Copy link
Member

rolinh commented Feb 26, 2020

@geakstr It looks like this library is not maintained anymore. From the readme:

As of Feb 11th 2020, request is fully deprecated. No new changes are expected to land. In fact, none have landed for some time.

See also this issue. It looks like it's time to consider an alternative.

@geakstr geakstr changed the title Revert back patch for request dep when fix is ready Replace request lib with something different in hubble-ui Feb 26, 2020
@geakstr
Copy link
Collaborator Author

geakstr commented Feb 26, 2020

@rolinh thanks, I've updated the title

@bengentil
Copy link

@geakstr Replacing request in hubble-ui in not sufficient, request is used almost everywhere in the kubernetes-client, so this depends also on kubernetes-client/javascript#414

@geakstr geakstr closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 area/ui This impacts the Hubble UI
Projects
None yet
Development

No branches or pull requests

3 participants