Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the OPA version bump workflow to work with the new README #1187

Closed
buidav opened this issue Jun 28, 2024 · 3 comments 路 Fixed by #1188
Closed

Fix the OPA version bump workflow to work with the new README #1187

buidav opened this issue Jun 28, 2024 · 3 comments 路 Fixed by #1188
Assignees
@buidav
Labels
bug This issue or pull request addresses broken functionality
Milestone
Iceberg

Comments

@buidav
Copy link
Collaborator

buidav commented Jun 28, 2024

馃悰 Summary

The OPA version bump workflow used to regularly bump the OPA version is currently erroring out do to the README changes.
This issue

To reproduce

View the errors in the latest OPA version bump workflows.

Expected behavior

For the workflows to bump the versions without any errors.
@buidav buidav added the bug This issue or pull request addresses broken functionality label Jun 28, 2024
@buidav buidav added this to the Iceberg milestone Jun 28, 2024
@buidav buidav self-assigned this Jun 28, 2024
@schrolla
Copy link
Collaborator

This is part of #1133 which was put in as a known issue resulting from the updated documentation. Currently planned to be worked in the upcoming sprint 2.

@buidav buidav mentioned this issue Jun 28, 2024
Merged
17 tasks
@buidav buidav linked a pull request Jun 28, 2024 that will close this issue
Fix the OPA version bump workflow to work with the new README #1188
Merged
17 tasks
@buidav
Copy link
Collaborator Author

buidav commented Jun 28, 2024

This is part of #1133 which was put in as a known issue resulting from the updated documentation. Currently planned to be worked in the upcoming sprint 2.

That issue is more for the ScubaGear version right?
That will be a need little more code to fix that this issue :).

@james-garriss
Copy link
Collaborator

I think the real solution to this sort of problem is related to the "we don't have all of our static requirements in one constants/config file" problem that other issues have brought up. IOW, this isn't a uniquely OPA problem. The README also talks about the names/versions of the PS modules that are installed. We should solve the problem one time, one way for everything, instead of piece-mealing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buidav buidav

Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
Iceberg
Development

Successfully merging a pull request may close this issue.

Fix the OPA version bump workflow to work with the new README cisagov/ScubaGear
3 participants
@james-garriss @buidav @schrolla