Skip to content

Commit 8b2de30

Browse files
rubocop hardcoded to 0.34.2
1 parent a93f45b commit 8b2de30

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

cisco_node_utils.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Currently supports NX-OS nodes.
3030
spec.add_development_dependency 'minitest', '~> 5.0'
3131
spec.add_development_dependency 'bundler', '~> 1.7'
3232
spec.add_development_dependency 'rake', '~> 10.0'
33-
spec.add_development_dependency 'rubocop', '~> 0.34'
33+
spec.add_development_dependency 'rubocop', '= 0.34.2'
3434
spec.add_development_dependency 'simplecov', '~> 0.9'
3535
spec.add_runtime_dependency 'cisco_nxapi', '~> 1.0'
3636
end

docs/README-maintainers.md

+9-5
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ Most of these are default for git-flow except for the `versiontag` setting.
3434

3535
When we are considering publishing a new release, all of the following steps must be carried out (using the latest code base in `develop`):
3636

37-
1. Run full minitest suite with various Ruby versions and hardware platforms:
37+
1. Review cisco_node_utils.gemspec
38+
* Is the data still relevant?
39+
* Do the version dependencies need to be updated? (e.g. rubocop)
40+
41+
2. Run full minitest suite with various Ruby versions and hardware platforms:
3842
* Ruby versions:
3943
- REQUIRED: the Ruby version(s) bundled with Chef and Puppet (currently 2.1.6)
4044
- OPTIONAL: any/all other Ruby major versions currently supported by this gem (2.0, 2.2.2)
@@ -43,13 +47,13 @@ When we are considering publishing a new release, all of the following steps mus
4347
- N31xx
4448
- N9xxx
4549

46-
2. Triage any minitest failures.
50+
3. Triage any minitest failures.
4751

48-
3. Check code coverage results from minitest to see if there are any critical gaps in coverage.
52+
4. Check code coverage results from minitest to see if there are any critical gaps in coverage.
4953

50-
4. Build gem and test it in combination with the latest released Puppet module (using Beaker and demo manifests) to make sure no backward compatibility issues have been introduced.
54+
5. Build gem and test it in combination with the latest released Puppet module (using Beaker and demo manifests) to make sure no backward compatibility issues have been introduced.
5155

52-
5. Make sure CHANGELOG.md accurately reflects all changes since the last release.
56+
6. Make sure CHANGELOG.md accurately reflects all changes since the last release.
5357
* Add any significant changes that weren't documented in the changelog
5458
* Clean up any entries that are overly verbose, unclear, or otherwise could be improved.
5559

0 commit comments

Comments
 (0)