Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializer GUI tool allows the author to be empty. #863

Open
Zumitify opened this issue Dec 20, 2023 · 2 comments
Open

Initializer GUI tool allows the author to be empty. #863

Zumitify opened this issue Dec 20, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Zumitify
Copy link

If there are no authors added, the initializer tool says that the Citation file is invalid.
But if we do the following steps:

  1. Add basic information, click next to go on the Authors page.
  2. No authors are present, hence it shows error and warning "Add at least one author"
  3. Click add Person, and then click done.

This adds an empty dictionary for the author field.
It then allows me to download the citation file, because there are no errors caught.

I am not sure if this is intended or not.

image

@Zumitify Zumitify added the bug Something isn't working label Dec 20, 2023
@sdruskat
Copy link
Member

sdruskat commented Jan 9, 2024

Thanks @Zumitify for reporting this. I'll transfer it to the repository for the cffinit tool that this refers to.

@sdruskat sdruskat transferred this issue from citation-file-format/citation-file-format Jan 9, 2024
@jspaaks
Copy link
Member

jspaaks commented Jan 15, 2024

Hi @Zumitify, thanks for making the issue. I can confirm the reported behavior is what is expected given the schema, although admittedly it is a bit weird and will likely change in the next release of the Citation File Format.

See the relevant PR here citation-file-format/citation-file-format#462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants