Network IDs around 65534 have issues networking successfully

[uowaep]

What happened?

I've found that over a long period of time, this happens very rarely. I've caught it 4 times total. One was at 65533
and three were at 65534. For me it happens when creating an object on the server, then trying to use NetworkGetEntityIsNetworked() on the client for the netid. It always returns false. Unfortunately I can't confirm more than that, but I will update with more information when it happens again.

Expected result

NetworkGetEntityIsNetworked() should return true

Reproduction steps

On the server:
local e = CreateObjectNoOffset(mdl, coords, true, true, false)
local netid = NetworkGetNetworkIdFromEntity(e)

when netid is around 65534, then on the client:
(not 100% which returns false first but...)

NetworkDoesEntityExistWithNetworkId() and/or NetworkGetEntityIsNetworked() happen next, and if my suspicion is correct, NetworkGetEntityIsNetworked() actually fails after NetworkDoesEntityExistWithNetworkId() succeeds, but I have to create a test case to know.

I suspect the latter because I'm finding reports of objects with these netids meaning they exist, but return false when queried if their netid does exist, unless the id i'm getting from NetworkGetEntityFromNetworkId() is 0.

Importancy

Slight inconvenience

Area(s)

FiveM, OneSync

Specific version(s)

FiveM server build 3407, linux and windows

Additional information

If you need a test case I'm willing to write one.

[gtolontop]

Hey! Really strange one indeed haha I think I might have found a lead. The netids 65533 and 65534 are suspiciously close to the maximum value of an unsigned 16-bit integer (65535 / 0xFFFF), so this could be an overflow or wrapping issue on the OneSync side. Would you be able to write the test case you mentioned please so I can test my patch?

[Qu3rt]

I've been noticing this myself as well. It started happening lately, but the pattern's the same. Having more players make's this bug almost game breaking. Every entity that tries to get created from client side doesn't get a network id assigned and so doesn't network. I think this is coming from the last 25770 server artifacts, I'll try to revert to older artifacts that I used and see if this keeps happening. Shouldn't be a problem for my server since it's running 3258 Game Build.

[uowaep]

Been trying to reproduce it, but it's harder than it seems. Maybe it's just that I need to wait for the network to resolve on the client in some cases because I definitely get 0 with NetworkGetEntityFromNetworkId(), but it does return the correct entity eventually.

I wonder if it just occurs more or takes longer to get the id around the max integer for unknown reasons, because the id doesn't need to be around 65535 for NetworkGetEntityFromNetworkId() to return 0.

If it happens on the live server again after I patch it, I'll give another update.