Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve dependency tree #347

Open
danyi1212 opened this issue Feb 16, 2021 · 6 comments
Open

Unable to resolve dependency tree #347

danyi1212 opened this issue Feb 16, 2021 · 6 comments

Comments

@danyi1212
Copy link

Hey, I'm getting those errors when trying to install this module:

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0" from [email protected]
npm ERR! node_modules/react-waypoint
npm ERR!   react-waypoint@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Is that because the react version? React 17 is not supported?

@Sergecodes
Copy link

Sergecodes commented Feb 21, 2021

@danyi1212 Yeah, I think that's why.
I did "npm i react-waypoint --force" to workaround this.

@renatobenks
Copy link

I think it should be closed once react@17 is already as peer dependency over here https://github.com/civiccc/react-waypoint/blob/master/package.json#L39

@renatobenks
Copy link

cc @lencioni @trotzig

@DesignByOnyx
Copy link

The latest published version v9.0.3 (from July 2020) does not contain this fix, which was added in Nov. 2020.

@slorber
Copy link

slorber commented Mar 16, 2021

Can someone release the code on master please?

@lencioni @trotzig @sds @eslingerbryan @johndotpub @jamesplease

@renatobenks
Copy link

@lencioni shouldn't you close this one once it was solved since https://github.com/civiccc/react-waypoint/releases/tag/v10.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants