Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Green highlights for installed extensions overridden #459

Open
ufundo opened this issue Jul 14, 2020 · 0 comments
Open

Green highlights for installed extensions overridden #459

ufundo opened this issue Jul 14, 2020 · 0 comments

Comments

@ufundo
Copy link

ufundo commented Jul 14, 2020

Hi,

Just another fairly cosmetic issue I have noticed, the green highlights for installed extensions on /civicrm/admin/extensions page seem to be hidden by Shoreditch CSS.

screenshot:
image

desired:
image

It looks like the green highlight should be generated by this rule:

.crm-container .extension-installed {
    background-color: #DDFFDD !important;
}

But this is overridden by this monster:

.crm-container .ui-dialog table tr, .crm-container>table tr, .crm-container table.report-layout tr, .crm-container table.selector tr, .crm-container table.row-highlight tr, .crm-container table.dataTable tr, .crm-container table.crm-multifield-selector tr, .crm-container .ui-dialog table tr, .crm-container .CRM_HRRecruitment_Form_Search>table tr, .crm-container .CRM_Case_Form_Search .caseSelector tr, .crm-container .CRM_Activity_Form_Activity>.crm-activity-view-block>.crm-info-panel tr, .crm-container #preview-counts tr, .crm-container #summary-counts tr, .crm-container #DataTables_Table_0 tr, .crm-container #DataTables_Table_1 tr, .page-civicrm-api .crm-container #api-params-table tr, .page-civicrm-contact-add .crm-container[role='dialog'] .row-highlight tr, .page-civicrm-import-contact #map-field>table tr, .page-civicrm-import-activity #map-field>table tr, .page-civicrm-import-custom #map-field>table tr, .page-civicrm-event-import #map-field>table tr, .page-civicrm-group #DataTables_Table_0 tr, .page-civicrm-contact-deduperules #crm-main-content-wrapper div[id*='browseValues_'] table tr, .page-civicrm-contact-deduperules table.mergecontact tr, .page-civicrm-contact-deduperules #DedupeRules .crm-dedupe-rules-form-block .form-layout-compressed tr, .crm-container #DedupeRules .crm-dedupe-rules-form-block-fields table.form-layout-compressed tr, .page-civicrm-dedupe-exception #dedupeExceptions tr, .page-civicrm-contact-view .crm-container .crm-discount-view-form-block .crm-info-panel tr, .page-civicrm-contact-view .CRM_Grant_Form_Search .row-highlight tr, .page-civicrm-contact-merge .crm-container .row-highlight tr, body[class*='page-civicrm-report-'] #report-tab-order-by-elements #optionField tr, .page-civicrm-activity .crm-container[role='dialog'] .row-highlight tr, .page-civicrm-tag #cat table tr, .crm-container .CRM_Member_Form_Search .selector tr, .crm-container .CRM_Member_Form_Search .report tr, .page-civicrm-member-search .selector tr, .crm-container .CRM_Member_Form_Task_Print table tr, .crm-container #Participant table#info tr, .crm-container #Participant .crm-event-participantview-form-block-fee_amount table tr, .crm-container #Participant table.selector tr, .crm-container #Participant .crm-event-eventfees-form-block-line_items table tr, .crm-container #ParticipantView table#info tr, .crm-container #ParticipantView .crm-event-participantview-form-block-fee_amount table tr, .crm-container #ParticipantView table.selector tr, .crm-container #ParticipantFeeSelection .crm-event-eventfees-form-block-line_items table tr, .page-civicrm-contribute-search .CRM_Contribute_Form_Search table.selector tr, .page-civicrm-contact-view .CRM_Contribute_Form_Search .selector tr, .crm-container form.CRM_Contribute_Form_ContributionCharts .selector tr, .crm-container form.CRM_Contribute_Form_ContributionCharts .report tr, .crm-container .CRM_Contribute_Form_Task_Print table tr, .page-civicrm-admin-price .CRM_Price_Form_Field #optionField tr, .page-civicrm-member-import #map-field table tr, .page-civicrm-member-import #preview-counts tr, .page-civicrm-member-import #summary-counts tr, .crm-container .CRM_Contact_Form_Task_AddToHousehold fieldset>table tr, .crm-container .CRM_Contact_Form_Task_AddToOrganization fieldset>table tr, .crm-container #changeLog table tr, .page-civicrm-contact-view #Search.CRM_Pledge_Form_Search table.selector tr, .page-civicrm-admin.page-civicrm-admin-custom .form-layout #multiple #optionField tr, .page-civicrm-a.page-civicrm-admin-custom .form-layout #multiple #optionField tr, .page-civicrm-admin.page-civicrm-admin-component #ltype .form-item table tr, .page-civicrm-a.page-civicrm-admin-component #ltype .form-item table tr, .page-civicrm-survey-configure .crm-content-block>#mainTabContainer .crm-campaign-survey-results-form-block fieldset table tr, .page-civicrm-case .selector tr, .page-civicrm-case .report tr, .crm-container .CRM_Case_Form_CaseView .dataTable tr, .crm-container .CRM_Case_Form_CaseView .report tr, .page-civicrm-batchtransaction .crm-container .CRM_Financial_Form_BatchTransaction #batch-summary tr, .page-civicrm-grant .CRM_Grant_Form_Search .selector tr, .page-civicrm-grant .CRM_Grant_Form_Search .report tr, .page-civicrm-pledge .CRM_Pledge_Form_Search .selector tr, .page-civicrm-pledge .CRM_Pledge_Form_Search .report tr, .crm-container.ui-dialog table tr, .crm-container .CRM_Contribute_Form_ContributionView #info tr, .crm-container .CRM_Contact_Form_Search_Advanced .crm-results-block table.selector tr, .crm-container .CRM_Contact_Form_Search_Basic .crm-results-block table.selector tr, .crm-container .CRM_Event_Form_Search .crm-results-block table.selector tr, .crm-container .CRM_Campaign_Form_Search .crm-results-block table.selector tr, .crm-container .CRM_Grant_Form_Search .crm-results-block table.selector tr, .crm-container .CRM_Pledge_Form_Search .crm-results-block table.selector tr, .crm-container .CRM_Contribute_Form_Search .crm-results-block table.selector tr, .crm-container .CRM_Activity_Form_Search .crm-results-block table.selector tr, .crm-container .CRM_Member_Form_Search .crm-results-block table.selector tr, .page-civicrm-campaign .CRM_Campaign_Form_Task_Interview .civireport-criteria .form-layout-compressed tr {
    background: #fff !important;
}

Even if that override is fixed, the background-color on the table rows is also hidden by a white background on the table cells:

.page-civicrm-admin.page-civicrm-admin-extensions #mainTabContainer #extensions-addnew table#option11 tr.extension-installed td, .page-civicrm-admin.page-civicrm-admin-extensions #mainTabContainer #extensions-addnew table#option12 tr.extension-installed td, .page-civicrm-admin.page-civicrm-admin-extensions #mainTabContainer #extensions-main table#option11 tr.extension-installed td, .page-civicrm-admin.page-civicrm-admin-extensions #mainTabContainer #extensions-main table#option12 tr.extension-installed td, .page-civicrm-a.page-civicrm-admin-extensions #mainTabContainer #extensions-addnew table#option11 tr.extension-installed td, .page-civicrm-a.page-civicrm-admin-extensions #mainTabContainer #extensions-addnew table#option12 tr.extension-installed td, .page-civicrm-a.page-civicrm-admin-extensions #mainTabContainer #extensions-main table#option11 tr.extension-installed td, .page-civicrm-a.page-civicrm-admin-extensions #mainTabContainer #extensions-main table#option12 tr.extension-installed td {
    background: #fafafb !important;
}

Seems especially strange that last rule even specifies some tr.extension-installed tds ─ but have no understanding of how this works so wouldn't know where to start with fixing.

Shoreditch 1.0.0-beta.1
CiviCRM 5.20.3
Drupal 7.72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant