Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricted editing buttons are in wrong menus #16609

Closed
scofalik opened this issue Jun 24, 2024 · 0 comments 路 Fixed by #16622
Closed

Restricted editing buttons are in wrong menus #16609

scofalik opened this issue Jun 24, 2024 · 0 comments 路 Fixed by #16622
Assignees
@DawidKossowski
Labels
package:ui squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 76

Comments

@scofalik
Copy link
Contributor

馃摑 Provide detailed reproduction steps (if any)

It seems to me that the restricted editing buttons are in the wrong menus. Switching between "exception" fields should be in "View". Adding "exception" field should be in "Insert". It seems it's the other way around:

	{
		menuId: 'view',
		label: 'View',
		groups: [
			{
				groupId: 'sourceEditing',
				items: [
					'menuBar:sourceEditing'
				]
			},
			{
				groupId: 'showBlocks',
				items: [
					'menuBar:showBlocks'
				]
			},
			{
				groupId: 'restrictedEditingException',
				items: [
					'menuBar:restrictedEditingException'
				]
			}
		]
	},
	{
		menuId: 'insert',
		label: 'Insert',
		groups: [
			// ...
			{
				groupId: 'restrictedEditing',
				items: [
					'menuBar:restrictedEditing'
				]
			}
		]
	},
@scofalik scofalik added type:bug This issue reports a buggy (incorrect) behavior. package:ui squad:collaboration Issue to be handled by the Collaboration team. labels Jun 24, 2024
@DawidKossowski DawidKossowski mentioned this issue Jun 27, 2024
Merged
@DawidKossowski DawidKossowski self-assigned this Jun 27, 2024
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jun 28, 2024
@CKEditorBot CKEditorBot mentioned this issue Jun 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DawidKossowski DawidKossowski

Labels
package:ui squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 76
Development

Successfully merging a pull request may close this issue.

Changed the place of restricted editing buttons in menu bar ckeditor/ckeditor5
3 participants
@scofalik @DawidKossowski @CKEditorBot