Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use TrackChanges plugin while customizing comments features #17643

Open
bendemboski opened this issue Dec 13, 2024 · 0 comments
Open

Cannot use TrackChanges plugin while customizing comments features #17643

bendemboski opened this issue Dec 13, 2024 · 0 comments
Labels
squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@bendemboski
Copy link
Contributor

πŸ“ Provide detailed reproduction steps (if any)

Create a CKEditor build that uses the TrackChanges glue plugin, but instead of using the Comments glue plugin, uses CommentsEditing and CommentsUI.

βœ”οΈ Expected result

It works

❌ Actual result

Uncaught (in promise) CKEditorError: plugincollection-soft-required {"missingPlugin":"Comments","requiredBy":"TrackChanges"}
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-plugincollection-soft-required
    at checkMissingPlugin (plugincollection.js:262:23)
    at plugincollection.js:229:17
    at Array.forEach (<anonymous>)
    at validatePlugins (plugincollection.js:228:18)
    at plugincollection.js:215:21
    at Array.reduce (<anonymous>)
    at getPluginConstructors (plugincollection.js:209:18)
    at PluginCollection.init (plugincollection.js:154:40)
    at Editor.initPlugins (editor.js:456:29)
    at editor.ts:211:12

❓ Possible solution

If the TrackChanges plugin were to have a soft requirement on the individual plugins it actually cares about (does it actually depend on the CommentsOnly plugin or on the CommentsArchive plugin?) rather than the whole Comments glue plugin, then builds could use the TrackChanges plugin while also customizing the comments features/plugins.

πŸ“ƒ Other details

  • First affected CKEditor version: CKEditor 44

Our use case is that we don't want the CommentsOnly or CommentsArchive plugins inflating our bundle or adding to runtime overhead, so we include CommentsEditing and CommentsUI instead. But we want all of the track changes functionality, so we want to use the TrackChanges plugin, but can't.


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@bendemboski bendemboski added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 13, 2024
@andrzejkala andrzejkala added the squad:collaboration Issue to be handled by the Collaboration team. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants