Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double submit when commenting #227

Open
jodator opened this issue Sep 11, 2020 · 1 comment · May be fixed by #432
Open

Double submit when commenting #227

jodator opened this issue Sep 11, 2020 · 1 comment · May be fixed by #432
Assignees
@illia-stv
Labels
bug Something isn't working has-pr squad:features

Comments

@jodator
Copy link

jodator commented Sep 11, 2020

Happened to me twice recently: I had a noticeable lag when clicking "submit" button on a GH issue which led me to double clicking it (I thought I miss-click).

The case was that the button appeared "disabled" IIRC and I just click on it again. The comment appear twice after GH refreshed the page and one of the comments was marked as similar to other one and hidden.
@jodator jodator added the bug Something isn't working label Sep 11, 2020
@mlewand
Copy link
Contributor

mlewand commented Oct 19, 2021

Also note that it should prevent double submit by pressing ctrl / cmd + enter.

@mateuszzagorski mateuszzagorski self-assigned this Oct 19, 2021
@FilipTokarski FilipTokarski mentioned this issue Mar 8, 2022
Open
@illia-stv illia-stv self-assigned this Nov 28, 2022
@illia-stv illia-stv linked a pull request Nov 30, 2022 that will close this issue
Open
@mlewand mlewand added the has-pr label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-stv illia-stv

Labels
bug Something isn't working has-pr squad:features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Double submit when commenting ckeditor/github-writer
4 participants
@jodator @mlewand @mateuszzagorski @illia-stv