-
Notifications
You must be signed in to change notification settings - Fork 173
Upgrade base to bootstrap 2.0? #9
Comments
i'm currently using this as swapable style, and since upgrading to newer bootstrap 2.0, i had to remove fbootstrap |
Would love to see an upgrade to bootstrap 2.0... |
I'll definitely look into a port. |
awesome. any idea on timing? |
for what it is worth, I'd be happy to help. let me know what you think. |
+1, I can help on porting to 2.0 |
Hey Andy, What do you mean a swappable style? |
Hey guys. Some help would be greatly appreciated, of course. |
congrats! keep us posted... |
@plainspace I should have said css style switcher, something like this, http://www.centerkey.com/style/switcher/ |
This just in: http://www.allfacebook.com/facebook-timeline-pages-2012-01 I wanted to bring this up anyways, so we might discuss it here: So, instead of just allowing the usage of the new elements within bootstrap 2.0, we might go for a proper 2.0 release of fbootstrapp which is built for the "new" look. |
+1 |
i think it makes sense to adopt new fb design elements. seems like using current profile timeline elements should do the trick. do you have an idea on timing? |
Sounds good, but what does it mean exactly? Which elements would be particularly interesting for fbootstrap? Unfortunately, noone really knows how the timeline pages will look, so should we wait for it? |
Yes, that is exactly what i was thinking about. In the meantime you can use the current version. |
Yep, fair enough, imho. |
Waiting for Facebook? Do you think they are going to change the canvas size? The fixed app canvas is currently 760 and the timeline canvas is 849. For some reason I don't think they are going to change the app canvas. It would mess up so many app developers. You can use the whole thing if you want anyway. What do you think of a making fbootstrapp 2.0 with the same element styles but with the ability to use a fixed or a fluid grid? Then people can customize the width but still retain the fb for bootstrap styles. I'd like to get working on a port to 2.0. Can you give me any tips about how you set it up with the current version? Are the styles all in one file or spread out over the less and css files? |
Sounds like what we have is a "wontfix" - basically fbootstrap will remain tied to Twitter Bootstrap 1, and future versions of FBootstrap will wait until the next (relentless) styling change Facebook rolls out. Correct? |
i wish it wasn't true! waiting for Facebook? ug. |
+1 for Bootstrap 2.0 support! I wouldn't wait for FB's new styles. |
@tmchow +1 |
The timeline for pages is here: https://www.facebook.com/about/pages Most important change for us is probably the new app width (810px). |
interesting. is the app width changing too? I don't see that yet on the dev tools. seems like page width and app width might not be the same? |
App width is 810px for page apps. I've added a new layout option and sent a pull request. |
Noticed this last night when my app looked ugly. Gotta love Facebook, their bugs, and their bug fix process. Maybe expect a real fix on Tuesday. |
So the app canvas is going to be the same width as the new page width? |
I'm not trying to tread on toes here, just providing my point of view: fbootstrapp is a project created based on Twitter's Bootstrap project - obvious, I know. ;) My point is that this project should primarily track its foundational features and functionality - that is, any changes in Twitter's Bootstrap should be reflected first and foremost. Anything else should be considered scope creep. I'm not saying that FB Timeline support shouldn't be added, but not at the expense of compatibility with the original Bootstrap or release timing. If possible, adding extra functionality like Timeline or new FB page widths should be an add-on. If approached this way, then perhaps upgrading when Bootstrap 3.0 is released might be easier. Edit: Perhaps a plugin or module based-approach might be feasible? LESS is quite flexible, so this should be realistic. I use a great 3rd party app available here https://github.com/earle/django-bootstrap to make Django forms work seamlessly with Twitter Bootstrap; for a while (pre-Bootstrap 2.0), this worked well with this Facebook version of Bootstrap. But then things fell apart with the 2.0 release. Anyhow, just some feedback on the project's approach - I don't think anyone expected such significant changes in Bootstrap, so it was hard to predict. |
+1 |
1 similar comment
+1 |
+1 |
2 similar comments
+1 |
+1 |
Any news on this? |
Hey, any news on this? Is there anything to test? |
+1 |
3 similar comments
+1 |
+1 |
+1 |
I'm not sure if this is a feasible request or not, but bootstrap 2.0 has been released (twitter's version). is it worth it to re-base this repo on the updated twitter-bootstrap?
I'm going to guess not...
The text was updated successfully, but these errors were encountered: