You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are issues with ISO files created by PowerISO that contain files that use non ascii characters. For example I stumbled upon a sample with Vietnamese letters. This causes pycdlib to crash with UnicodeDecodeError: 'utf8' codec can't decode byte 0xea in position 1: invalid continuation byte
The encoding used appears to be latin-1 in this scenario, however the parser does not seem to pick this up. I believe relaxing the decoding scheme ( errors='ignore' ) could potentially solve (at least partially) the issue. I did not have the chance to test or analyse this in depth (especially for Rock Ridge/Joliet).
I cant attach ISO files in this form but it's quite simple to reproduce:
PowerISo 32 bit -> new image
Add a file (or folders) that contain non standard characters (my sample has "Yêu cầu ưu đãi" in the file name).
Open the file with pycdlib and try to call the walk method. Will result in the error mentioned above.
The text was updated successfully, but these errors were encountered:
Yeah, this is similar to #75 . In short, the library currently only uses ASCII encoding, as that is what is called out in the specification. We can probably lift the restriction pretty easily, but I still haven't been able to create an ISO that has these characters. Every time I try with PowerIso, it won't let me use non-ASCII characters. I'll try again at some point.
So I finally got a chance to look at this, and I think with the changes that I made for #75, this is now fixed. That said, I ended up adding in a specific test for Vietnamese in 312f19a .
With all of that said, I'm going to close this out. Feel free to reopen if you think this is still a problem.
There are issues with ISO files created by PowerISO that contain files that use non ascii characters. For example I stumbled upon a sample with Vietnamese letters. This causes pycdlib to crash with
UnicodeDecodeError: 'utf8' codec can't decode byte 0xea in position 1: invalid continuation byte
The encoding used appears to be latin-1 in this scenario, however the parser does not seem to pick this up. I believe relaxing the decoding scheme (
errors='ignore'
) could potentially solve (at least partially) the issue. I did not have the chance to test or analyse this in depth (especially for Rock Ridge/Joliet).I cant attach ISO files in this form but it's quite simple to reproduce:
The text was updated successfully, but these errors were encountered: