Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Detector Pod phase status do not correctily not filter pod linked jobs #556

Open
antonin-rouault opened this issue May 15, 2024 · 0 comments
Labels
bug Something isn't working detectors About nex or existing detectors

Comments

@antonin-rouault
Copy link

What is the module?
otel-collector_kubernetes-common

What is the detector?
pod_phase_status
https://github.com/claranet/terraform-signalfx-detectors/blob/c94f90c18ab1cfbeef1efb4736ca830be20399b0/modules/otel-collector_kubernetes-common/detectors-gen.tf#L99C31-L99C47

Describe the bug
when one or more pods linked to a job fail, theoretically, the detector should not trigger any alert.
But in the end we have many alerts triggered on pods linked to jobs.

To Reproduce
Steps to reproduce the behavior:

  1. start a job doomed to fail
  2. observe the monitoring in signalfx
  3. Moment / situation when detector falsely raise (or not) alert

Expected behavior
A clear and concise description of what you expected to happen and difference compared to previous section.
the detector should not raise any alert when a pod linked to a job fails

resolution
replace the base-filtering filter (not filter('k8s.job.name', '*')) and (not filter('cronk8s.job.name', '*')) by (not filter('k8s.job.uid', '*')) and (not filter('cronk8s.job.uid', '*'))

base_filtering = (not filter('k8s.job.name', '*')) and (not filter('cronk8s.job.name', '*'))

@antonin-rouault antonin-rouault added bug Something isn't working detectors About nex or existing detectors labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working detectors About nex or existing detectors
Projects
None yet
Development

No branches or pull requests

1 participant