Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating creatures on every state change is slow #9

Open
clark-lindsay opened this issue Oct 1, 2020 · 0 comments
Open

generating creatures on every state change is slow #9

clark-lindsay opened this issue Oct 1, 2020 · 0 comments
Labels
enhancement New feature or request performance

Comments

@clark-lindsay
Copy link
Owner

Whether or not the current method of deciding if the current parameter set selected by the user is slowing down the app considerably, it is certainly using a lot of resources. Not something that I want to be true about this app.

Possible Solution

instead of calling the generator after every change to state, we could call it only when the user clicks the button, and if their parameters would result in an empty list, then we can render the error message and disable the button until the parameter list changes (maybe a reactive variable looking at the current state of the readSpellParameters store?)

@clark-lindsay clark-lindsay added enhancement New feature or request performance labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

1 participant