Generate random values for undefineds when pokeing #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
requested changes
Mar 21, 2024
lmbollen
force-pushed
the
ffi-undefined-to-random-storable
branch
from
08b2217
to
edc983a
Compare
lmbollen
force-pushed
the
ffi-undefined-to-random-storable
branch
2 times, most recently
from
7667c6f
to
05ec8b0
Compare
martijnbastiaan
requested changes
Apr 4, 2024
lmbollen
force-pushed
the
ffi-undefined-to-random-storable
branch
5 times, most recently
from
c081831
to
a0e97f4
Compare
martijnbastiaan
approved these changes
Apr 10, 2024
lmbollen
force-pushed
the
ffi-undefined-to-random-storable
branch
from
a0e97f4
to
4a06e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current FFI implementation does not handle undefined values.
This PR changes the storable instances of the inputs to vexrisc such that
pokechecks if a value has undefined bits.If the value has undefined bits we generate a random value.
Do note that partially undefined values will get completely new randomized values. At the moment I'm not sure how to best implement this, I'm open for suggestions or discussion.