Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clasp release archive 2.6.0 is still checking for git program #1590

Open
Uthar opened this issue Jun 4, 2024 · 1 comment
Open

Clasp release archive 2.6.0 is still checking for git program #1590

Uthar opened this issue Jun 4, 2024 · 1 comment
Labels

Comments

@Uthar
Copy link

Uthar commented Jun 4, 2024

Describe the bug
Building from 2.6.0 release archive still checks for git.

Expected behavior
With the new release, dependencies which were previously downloaded from git are now bundled. With that the build should work on a system with no git installed.

Actual behavior
Running the koga initialisation script from an unpacked Clasp 2.6.0 archive stops with an error message when there is no git program installed on the system.

Steps to reproduce

  1. wget https://github.com/clasp-developers/clasp/releases/download/2.6.0/clasp-2.6.0.tar.gz
  2. tar xf clasp-2.6.0.tar.gz && cd clasp-2.6.0
  3. PATH='' $(which sbcl) --script ./koga --skip-sync
...
Found https://github.com/seqan/seqan.git clone in extensions/seqan-clasp/seqan/, assuming everything is okay.


Configuring the build
Configuring git
Unable to find git program.
@Uthar Uthar added the bug label Jun 4, 2024
@yitzchak yitzchak added cleanup and removed bug labels Jun 4, 2024
@yitzchak
Copy link
Member

yitzchak commented Jun 4, 2024

I haven't decided whether to remove this check yet. git is still used in some places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants