Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package reform #1602

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Package reform #1602

wants to merge 12 commits into from

Conversation

Bike
Copy link
Member

@Bike Bike commented Jun 22, 2024

Cleans some stuff up and, importantly, allows package names that aren't just base strings (#1596).

Unfortunately does not fix the way package objects are printed - which is relatively minor, but annoying. The problem is it goes through repr and that returns a std::string.

@Bike Bike marked this pull request as ready for review June 24, 2024 14:18
@Bike
Copy link
Member Author

Bike commented Jun 24, 2024

Fixed it up so package names print right now, so I think it fixes #1596.

@Bike Bike linked an issue Jun 24, 2024 that may be closed by this pull request
Bike added 12 commits June 24, 2024 19:25
Also start on making package functions accept Lisp strings instead
of std::strings. Using std::strings means no support for extended
strings, which is pretty dumb.
not every place, though. still working on it. but this is another
step towards not assuming package names are base strings.

and, bonus? Less stupid consing.
I'm leaving in the string one since we probably use it during boot
or for extensions or some crapola like that.
__repr__ is still broken but it's kind of dumb anyway. To fix it
we'd have to make it not return a std::string, I guess, which
would be a pretty severe change.
Previously it tested if the name was "", but that doesn't work
well given character strings, or the pathological case of an empty
name. We already have a "deleted" flag so we may as well use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended characters trip up packages
1 participant