ADR_ACK_LIMIT corrections.

Author: clavisound

Diff for: README.md

@@ -41,7 +41,6 @@ The majority of the work was done by Hendrik Hagendorn and Ideetron B.V. Thanks
 # MAC commands supported.
 
 - [x] ADR for Data Rate and TxPower. After join with SF9 in different room from gateway (RSSI -85), TTN sends SF7 (or SF8) ADR command and SlimLoRa conforms.
-- [x] ADR_ACK_LIMIT
 - [x] NbTrans
 - [x] Channel Mask
 - [x] RxTimingSetup
@@ -68,6 +67,7 @@ Solutions with avr style.
 
 # Semi-Working
 
+- [x] ADR_ACK_LIMIT, must follow directive on p. 17 based pn ADR_ACK_DELAY
 - [x] Duty Cycle. Added GetTXms function to return the TOTAL duration of ALL transmissions. At SF7 1byte reports 45-48ms vs 46ms [theoretical](https://avbentem.github.io/airtime-calculator/ttn/eu868/1) at SF8 reports 84ms vs 82ms (theoretical). SF7 5 bytes reports 52ms vs 51.5ms (theoretical). Application HAVE to read the value of GetTXms() after every transmission to check if the the Duty Cycle is respected. I decided to not respect Duty Cycle on SlimLoRa, since if the device is going to Deep Sleep and wakes up via a accelerometer on AVR MCU's freezes the timer0. I think the solution is the RTC or to read a time from GPS.
 - [x] Power to the people. Several values made public. Take care to not write them or you may loose access to the network. Instead of using getters I selected to make public some variables.
 - [x] MAC Commands. 

Diff for: SlimLoRa.cpp

@@ -758,6 +758,7 @@ void SlimLoRa::RfmSendPacket(uint8_t *packet, uint8_t packet_length, uint8_t cha
 	// semi TODO fCnt don't increase if we havee UNCONFIRMED_DATA_UP and NbTrans to do.
 	if ( NbTrans_counter == 0 ) {
 		tx_frame_counter_++;
+		adr_ack_counter_++;
 		NbTrans_counter = NbTrans;
 	}
 
@@ -767,7 +768,6 @@ void SlimLoRa::RfmSendPacket(uint8_t *packet, uint8_t packet_length, uint8_t cha
 		SetTxFrameCounter();
 	}
 #endif
-	adr_ack_counter_++;
 }
 
 /**
@@ -1870,9 +1870,9 @@ void SlimLoRa::Transmit(uint8_t fport, uint8_t *payload, uint8_t payload_length)
 	if (adr_enabled_) {
 		packet[packet_length] |= LORAWAN_FCTRL_ADR;
 
-		// Request ACK if data_rate is higher than 0 and adr_ack_counter_ is over the limit
+		// Request ADR if adr_ack_counter_ is over the limit of LORAWAN_ADR_ACK_LIMIT
 		// p. 17
-		if (adr_ack_counter_ >= LORAWAN_ADR_ACK_LIMIT && data_rate_ > 0 ) {
+		if (adr_ack_counter_ >= LORAWAN_ADR_ACK_LIMIT ) {
 			packet[packet_length] |= LORAWAN_FCTRL_ADR_ACK_REQ;
 		}
 	}

Diff for: library.json

@@ -1,6 +1,6 @@
 {
   "name": "SlimLoRa",
-  "version": "0.6.9",
+  "version": "0.6.11",
   "description": "LoRaWAN library with OTAA join, ADR support and most important MAC commands for EU868 suitable for AVR's with 32Kbytes. It uses 14kBytes of program flash instead of 52kBytes of RadioLib or 32kBytes of LMIC. Tested avr32u4 / ATmega32u4 and HopeRF 95w (SX1276) on Adafruit Feather. ABP untested. Session is stored to EEPROM. Testers wanted and PR's for other regions. It supports downlinks.",
   "keywords": "LoRaWAN, rfm95w, hoperf, SX1276, radio, communication",
   "repository":

Diff for: library.properties

@@ -1,5 +1,5 @@
 name=SlimLoRa
-version=0.6.9
+version=0.6.11
 author=clavisound
 maintainer=clavisound
 sentence=SlimLoRa Library