Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0391 'patch' may cause a crash #16

Open
DK22Pac opened this issue May 23, 2017 · 3 comments
Open

0391 'patch' may cause a crash #16

DK22Pac opened this issue May 23, 2017 · 3 comments
Labels
bug has solution

Comments

@DK22Pac
Copy link
Contributor

DK22Pac commented May 23, 2017

CLEO4/CLEO4/CScriptEngine.cpp

Line 653 in 07df664

inj.MemoryWrite(gvm.TranslateMemoryAddress(MA_CODE_JUMP_FOR_TXD_STORE), OP_RET);

This may cause a crash if you load/unload TXD many times.
https://sannybuilder.com/forums/viewtopic.php?id=4548
@x87
Copy link
Contributor

x87 commented May 23, 2017

@Deji69 any idea why do we have this function hooked?

@Deji69
Copy link

Deji69 commented May 25, 2017

Probably something to do with script dependent drawing.

@x87 x87 added the bug label Aug 3, 2017
@x87
Copy link
Contributor

x87 commented Aug 26, 2023

this patch can be undone in a script with

0A8C: write_memory 0x465A6F size 4 value 0x0D8B2774 virtual_protect 1 // CLEO

or

Memory.WriteU32(0x465A6F, 0x0D8B2774, true); // CLEO Redux

yet it's still not clear what it affects.

MiranDMC added a commit to MiranDMC/CLEO4 that referenced this issue Nov 13, 2023
@MiranDMC
support UAL's hack of find file APIs (cleolibrary#16)
a3c6924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has solution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@x87 @Deji69 @DK22Pac