Skip to content

Commit 6493721

Browse files
authored
Merge branch 'main' into jrad/fix-turbopack-ui-import
2 parents d86d52f + cd4403d commit 6493721

File tree

3 files changed

+40
-22
lines changed

3 files changed

+40
-22
lines changed

.changeset/wild-clocks-stare.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

integration/tests/next-quickstart-keyless.test.ts

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -89,20 +89,28 @@ test.describe('Keyless mode @quickstart', () => {
8989
await newPage.waitForLoadState();
9090

9191
await newPage.waitForURL(url => {
92-
const urlToReturnTo = `${dashboardUrl}apps/claim?token=`;
93-
92+
const signInForceRedirectUrl = url.searchParams.get('sign_in_force_redirect_url');
9493
const signUpForceRedirectUrl = url.searchParams.get('sign_up_force_redirect_url');
9594

96-
const signUpForceRedirectUrlCheck =
97-
signUpForceRedirectUrl?.startsWith(urlToReturnTo) ||
98-
(signUpForceRedirectUrl?.startsWith(`${dashboardUrl}prepare-account`) &&
99-
signUpForceRedirectUrl?.includes(encodeURIComponent('apps/claim?token=')));
95+
const signInHasRequiredParams =
96+
signInForceRedirectUrl?.includes(`${dashboardUrl}apps/claim`) &&
97+
signInForceRedirectUrl?.includes('token=') &&
98+
signInForceRedirectUrl?.includes('framework=nextjs');
99+
100+
const signUpRegularCase =
101+
signUpForceRedirectUrl?.includes(`${dashboardUrl}apps/claim`) &&
102+
signUpForceRedirectUrl?.includes('token=') &&
103+
signUpForceRedirectUrl?.includes('framework=nextjs');
104+
105+
const signUpPrepareAccountCase =
106+
signUpForceRedirectUrl?.startsWith(`${dashboardUrl}prepare-account`) &&
107+
signUpForceRedirectUrl?.includes(encodeURIComponent('apps/claim')) &&
108+
signUpForceRedirectUrl?.includes(encodeURIComponent('token=')) &&
109+
signUpForceRedirectUrl?.includes(encodeURIComponent('framework=nextjs'));
110+
111+
const signUpHasRequiredParams = signUpRegularCase || signUpPrepareAccountCase;
100112

101-
return (
102-
url.pathname === '/apps/claim/sign-in' &&
103-
url.searchParams.get('sign_in_force_redirect_url')?.startsWith(urlToReturnTo) &&
104-
signUpForceRedirectUrlCheck
105-
);
113+
return url.pathname === '/apps/claim/sign-in' && signInHasRequiredParams && signUpHasRequiredParams;
106114
});
107115
});
108116

integration/tests/tanstack-start/keyless.test.ts

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,28 @@ test.describe('Keyless mode @tanstack-react-start', () => {
6969
await newPage.waitForLoadState();
7070

7171
await newPage.waitForURL(url => {
72-
const urlToReturnTo = `${dashboardUrl}apps/claim?token=`;
73-
72+
const signInForceRedirectUrl = url.searchParams.get('sign_in_force_redirect_url');
7473
const signUpForceRedirectUrl = url.searchParams.get('sign_up_force_redirect_url');
7574

76-
const signUpForceRedirectUrlCheck =
77-
signUpForceRedirectUrl?.startsWith(urlToReturnTo) ||
78-
(signUpForceRedirectUrl?.startsWith(`${dashboardUrl}prepare-account`) &&
79-
signUpForceRedirectUrl?.includes(encodeURIComponent('apps/claim?token=')));
75+
const signInHasRequiredParams =
76+
signInForceRedirectUrl?.includes(`${dashboardUrl}apps/claim`) &&
77+
signInForceRedirectUrl?.includes('token=') &&
78+
signInForceRedirectUrl?.includes('framework=tanstack-react-start');
79+
80+
const signUpRegularCase =
81+
signUpForceRedirectUrl?.includes(`${dashboardUrl}apps/claim`) &&
82+
signUpForceRedirectUrl?.includes('token=') &&
83+
signUpForceRedirectUrl?.includes('framework=tanstack-react-start');
84+
85+
const signUpPrepareAccountCase =
86+
signUpForceRedirectUrl?.startsWith(`${dashboardUrl}prepare-account`) &&
87+
signUpForceRedirectUrl?.includes(encodeURIComponent('apps/claim')) &&
88+
signUpForceRedirectUrl?.includes(encodeURIComponent('token=')) &&
89+
signUpForceRedirectUrl?.includes(encodeURIComponent('framework=tanstack-react-start'));
90+
91+
const signUpHasRequiredParams = signUpRegularCase || signUpPrepareAccountCase;
8092

81-
return (
82-
url.pathname === '/apps/claim/sign-in' &&
83-
url.searchParams.get('sign_in_force_redirect_url')?.startsWith(urlToReturnTo) &&
84-
signUpForceRedirectUrlCheck
85-
);
93+
return url.pathname === '/apps/claim/sign-in' && signInHasRequiredParams && signUpHasRequiredParams;
8694
});
8795
});
8896

0 commit comments

Comments
 (0)