Skip to content

Commit c962cca

Browse files
committed
fix: rename shouldPrefetchClerkUi to shouldPrefetchClerkUI for consistency
1 parent a708fb2 commit c962cca

File tree

9 files changed

+18
-18
lines changed

9 files changed

+18
-18
lines changed

packages/astro/src/internal/create-clerk-instance.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {
22
loadClerkJsScript,
33
loadClerkUiScript,
44
setClerkJsLoadingErrorPackageName,
5-
shouldPrefetchClerkUi,
5+
shouldPrefetchClerkUI,
66
} from '@clerk/shared/loadClerkJsScript';
77
import type { ClerkOptions } from '@clerk/shared/types';
88
import type { ClerkUiConstructor } from '@clerk/shared/ui';
@@ -117,7 +117,7 @@ async function getClerkJsEntryChunk<TUi extends Ui = Ui>(options?: AstroClerkCre
117117
async function getClerkUiEntryChunk<TUi extends Ui = Ui>(
118118
options?: AstroClerkCreateInstanceParams<TUi>,
119119
): Promise<ClerkUiConstructor | undefined> {
120-
if (!shouldPrefetchClerkUi(options?.prefetchUI)) {
120+
if (!shouldPrefetchClerkUI(options?.prefetchUI)) {
121121
return undefined;
122122
}
123123

packages/astro/src/server/build-clerk-hotload-script.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { clerkJsScriptUrl, clerkUiScriptUrl, shouldPrefetchClerkUi } from '@clerk/shared/loadClerkJsScript';
1+
import { clerkJsScriptUrl, clerkUiScriptUrl, shouldPrefetchClerkUI } from '@clerk/shared/loadClerkJsScript';
22
import type { APIContext } from 'astro';
33

44
import { getSafeEnv } from './get-safe-env';
@@ -30,7 +30,7 @@ function buildClerkHotloadScript(locals: APIContext['locals']) {
3030
${domain ? `data-clerk-domain="${domain}"` : ``}
3131
></script>`;
3232

33-
if (!shouldPrefetchClerkUi(env.prefetchUI)) {
33+
if (!shouldPrefetchClerkUI(env.prefetchUI)) {
3434
return clerkJsScript + '\n';
3535
}
3636

packages/nextjs/src/utils/clerk-script.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
buildClerkUiScriptAttributes,
55
clerkJsScriptUrl,
66
clerkUiScriptUrl,
7-
shouldPrefetchClerkUi,
7+
shouldPrefetchClerkUI,
88
} from '@clerk/react/internal';
99
import NextScript from 'next/script';
1010
import React from 'react';
@@ -69,7 +69,7 @@ export function ClerkScripts({ router }: { router: ClerkScriptProps['router'] })
6969
dataAttribute='data-clerk-js-script'
7070
router={router}
7171
/>
72-
{shouldPrefetchClerkUi(prefetchUI) && (
72+
{shouldPrefetchClerkUI(prefetchUI) && (
7373
<ClerkScript
7474
scriptUrl={clerkUiScriptUrl(opts)}
7575
attributes={buildClerkUiScriptAttributes(opts)}

packages/react/src/__tests__/isomorphicClerk.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { IsomorphicClerk } from '../isomorphicClerk';
77
vi.mock('@clerk/shared/loadClerkJsScript', () => ({
88
loadClerkJsScript: vi.fn().mockResolvedValue(null),
99
loadClerkUiScript: vi.fn().mockResolvedValue(null),
10-
shouldPrefetchClerkUi: vi.fn().mockReturnValue(true),
10+
shouldPrefetchClerkUI: vi.fn().mockReturnValue(true),
1111
}));
1212

1313
describe('isomorphicClerk', () => {

packages/react/src/internal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export {
99
clerkUiScriptUrl,
1010
buildClerkUiScriptAttributes,
1111
setClerkJsLoadingErrorPackageName,
12-
shouldPrefetchClerkUi,
12+
shouldPrefetchClerkUI,
1313
} from '@clerk/shared/loadClerkJsScript';
1414

1515
export type { Ui } from '@clerk/ui/internal';

packages/react/src/isomorphicClerk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { inBrowser } from '@clerk/shared/browser';
22
import { clerkEvents, createClerkEventBus } from '@clerk/shared/clerkEventBus';
3-
import { loadClerkJsScript, loadClerkUiScript, shouldPrefetchClerkUi } from '@clerk/shared/loadClerkJsScript';
3+
import { loadClerkJsScript, loadClerkUiScript, shouldPrefetchClerkUI } from '@clerk/shared/loadClerkJsScript';
44
import type {
55
__internal_AttemptToEnableEnvironmentSettingParams,
66
__internal_AttemptToEnableEnvironmentSettingResult,
@@ -509,7 +509,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
509509
}
510510

511511
private async getClerkUiEntryChunk(): Promise<ClerkUiConstructor | undefined> {
512-
if (!shouldPrefetchClerkUi(this.options.prefetchUI)) {
512+
if (!shouldPrefetchClerkUI(this.options.prefetchUI)) {
513513
return undefined;
514514
}
515515

packages/shared/src/__tests__/loadClerkJsScript.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
loadClerkJsScript,
1212
loadClerkUiScript,
1313
setClerkJsLoadingErrorPackageName,
14-
shouldPrefetchClerkUi,
14+
shouldPrefetchClerkUI,
1515
} from '../loadClerkJsScript';
1616
import { loadScript } from '../loadScript';
1717
import { getMajorVersion } from '../versionSelector';
@@ -465,16 +465,16 @@ describe('buildClerkUiScriptAttributes()', () => {
465465
});
466466
});
467467

468-
describe('shouldPrefetchClerkUi()', () => {
468+
describe('shouldPrefetchClerkUI()', () => {
469469
test('returns true when prefetchUI is undefined', () => {
470-
expect(shouldPrefetchClerkUi(undefined)).toBe(true);
470+
expect(shouldPrefetchClerkUI(undefined)).toBe(true);
471471
});
472472

473473
test('returns false when prefetchUI is false', () => {
474-
expect(shouldPrefetchClerkUi(false)).toBe(false);
474+
expect(shouldPrefetchClerkUI(false)).toBe(false);
475475
});
476476

477477
test('returns true when prefetchUI is true', () => {
478-
expect(shouldPrefetchClerkUi(true)).toBe(true);
478+
expect(shouldPrefetchClerkUI(true)).toBe(true);
479479
});
480480
});

packages/shared/src/loadClerkJsScript.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export type LoadClerkJsScriptOptions = {
3131
* @param prefetchUI - The prefetchUI option from ClerkProvider/options
3232
* @returns `true` if UI should be prefetched, `false` if it should be skipped
3333
*/
34-
export const shouldPrefetchClerkUi = (prefetchUI: boolean | undefined): boolean => {
34+
export const shouldPrefetchClerkUI = (prefetchUI: boolean | undefined): boolean => {
3535
return prefetchUI !== false;
3636
};
3737

packages/vue/src/plugin.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
loadClerkJsScript,
55
type LoadClerkJsScriptOptions,
66
loadClerkUiScript,
7-
shouldPrefetchClerkUi,
7+
shouldPrefetchClerkUI,
88
} from '@clerk/shared/loadClerkJsScript';
99
import type {
1010
Clerk,
@@ -84,7 +84,7 @@ export const clerkPlugin: Plugin<[PluginOptions]> = {
8484
try {
8585
const clerkPromise = loadClerkJsScript(options);
8686
// Skip UI loading when prefetchUI={false}
87-
const clerkUiCtorPromise = !shouldPrefetchClerkUi(pluginOptions.prefetchUI)
87+
const clerkUiCtorPromise = !shouldPrefetchClerkUI(pluginOptions.prefetchUI)
8888
? Promise.resolve(undefined)
8989
: pluginOptions.clerkUiCtor
9090
? Promise.resolve(pluginOptions.clerkUiCtor)

0 commit comments

Comments
 (0)