Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Feb 9, 2026

Description

Updates integration tests to handle the new framework query parameter in keyless claim URLs.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.
  • Tests

    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.
  • Chores

    • Added a release changeset entry.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

🦋 Changeset detected

Latest commit: 31fc985

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Feb 10, 2026 0:31am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 9, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985

@wobsoriano wobsoriano changed the title chore(repo): Fix keyless E2E tests fix(repo): Handle framework query param in keyless claim URLs integration tests Feb 10, 2026
@wobsoriano wobsoriano enabled auto-merge (squash) February 10, 2026 00:37
@wobsoriano wobsoriano merged commit cd4403d into main Feb 10, 2026
43 checks passed
@wobsoriano wobsoriano deleted the rob/fix-keyless-e2e branch February 10, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants