Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/pdct 1441 Add family_import_id and import_id to GCF document parser #12

Merged
merged 23 commits into from
Sep 5, 2024
Merged

feature/pdct 1441 Add family_import_id and import_id to GCF document parser #12

merged 23 commits into from
Sep 5, 2024

Conversation

katybaulch
Copy link
Collaborator

What's changed?

  • Add family_import_id and import_id to GCF document parser
  • Fixed docstring formatting inconsistency
  • Refactored document parser code into smaller functions
  • Changed document parser tests to use mock data instead of real GCF data & simplified fixtures

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

@katybaulch
Pull document enums into separate file
6787bca
@katybaulch
Check required columns don't have NA values helper
20a334a
@katybaulch
Test refactored document parser
bd82693
@katybaulch
Refactor document parser into smaller functions
c5a6c02
@katybaulch
Create test_commands.py
eaec824
@katybaulch
Move --version test to separate file
42a98f7
@katybaulch
Rename OptionalDocumentColumns to TranslatedDocumentColumns
a5d074d
@katybaulch
Explicitly return None
6765613
@katybaulch
Update comment for document parser processing.
914f651
@katybaulch
Docstring consistency
c0b6436
@katybaulch
Bump to 0.1.9
7eb6ec8
@katybaulch
Update cspell dict and removed file from trunk ignore
795a245
@katybaulch
Removed test duplication
baa281c
@katybaulch
Added pydantic to cpsell dict
ab3271c
@katybaulch
Move move fixtures for valid rows for docs with translations to conftest
d60aec2
@katybaulch
Move source URL to required doc columsn
516fe38
@katybaulch
Move mock data to conftest
1c32897
@katybaulch
Test process row returns None when NA in required cols
f065c53
@katybaulch
Remove dependency on enums in tests
d847fa2
@katybaulch
Fix enum names for IgnoreDocumentTypes
5f1e696
@katybaulch
Fix pyright error
107f4c3
@katybaulch katybaulch marked this pull request as ready for review September 5, 2024 12:12
@katybaulch katybaulch requested a review from a team as a code owner September 5, 2024 12:12
@katybaulch
Copy link
Collaborator Author

https://linear.app/climate-policy-radar/issue/PDCT-1441/add-family-import-id-to-gcf-document-mapping

annaCPR
annaCPR approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@annaCPR annaCPR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katybaulch katybaulch merged commit 57dfbe5 into main Sep 5, 2024
2 checks passed
@katybaulch katybaulch deleted the refactor-document-parser branch September 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annaCPR annaCPR annaCPR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katybaulch @annaCPR