Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pdct 1454 fix status should be a list not a string #18

Merged

Conversation

odrakes-cpr
Copy link
Contributor

What's changed?

Provide a general summary of your changes.

Quick updates to our functions to ensure that the data we are sending to the bulk import tool matches what it expects.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Osneil Drakes added 4 commits September 11, 2024 13:22
- when validating we expect these fields to be a list
 - this matches the fields that we expect in the database
- should contain 'family' not events
@odrakes-cpr odrakes-cpr requested a review from a team as a code owner September 11, 2024 14:01
Copy link

linear bot commented Sep 11, 2024

Copy link
Collaborator

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good spots!!

@odrakes-cpr odrakes-cpr merged commit 81f6f3f into main Sep 11, 2024
2 checks passed
@odrakes-cpr odrakes-cpr deleted the feature/pdct-1454-fix-status-should-be-a-list-not-a-string branch September 11, 2024 14:08
Copy link
Contributor

@annaCPR annaCPR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants