Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/pdct-1540-set-all-metadata-entries-to-a-string-type #24

Merged

Conversation

odrakes-cpr
Copy link
Contributor

@odrakes-cpr odrakes-cpr commented Oct 1, 2024

What's changed?

fix: ensure all metadata values are list of strings

  • vespa expects these values to be strings, if any other type is provided the ingest will fail

Provide a general summary of your changes.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

- vespa expects these values to be strings, if any other type is
  provided the ingest will fail
@odrakes-cpr odrakes-cpr requested a review from a team as a code owner October 1, 2024 11:54
Copy link

linear bot commented Oct 1, 2024

@odrakes-cpr odrakes-cpr requested a review from diversemix October 1, 2024 12:32
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@odrakes-cpr odrakes-cpr merged commit eeb8921 into main Oct 1, 2024
2 checks passed
@odrakes-cpr odrakes-cpr deleted the feature/pdct-1540-set-all-metadata-entries-to-a-string-type branch October 1, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants