Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/pdct-1554-map-gcf-source-url-to-document-pdf-not-url #25

Conversation

odrakes-cpr
Copy link
Contributor

@odrakes-cpr odrakes-cpr commented Oct 3, 2024

What's changed?

Provide a general summary of your changes.

fix: document source url points to pdf

  • we were incorrectly pointing to the permalink, not the url with that houses the pdf

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

- we were incorrectly pointing to the permalink, not the url with that
  housed the pdf
@odrakes-cpr odrakes-cpr requested a review from a team as a code owner October 3, 2024 07:14
Copy link

linear bot commented Oct 3, 2024

@odrakes-cpr odrakes-cpr requested a review from annaCPR October 3, 2024 07:44
Copy link
Contributor

@annaCPR annaCPR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@odrakes-cpr odrakes-cpr merged commit 933b4fa into main Oct 3, 2024
4 checks passed
@odrakes-cpr odrakes-cpr deleted the feature/pdct-1554-map-gcf-source-url-to-document-pdf-not-url branch October 3, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants