-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pgAdmin to docker compose for nice local admin UI #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code quality checks are failing but otherwise happy -- following up from our chat just now in the office I think we might benefit from starting to write our own dockerfiles and store them in ECR -- as I imagine this might be reusable between repos :) Nice work!
cc92347
to
c86363a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we probably want to fix the conflicting lint rules going forward though rather than ignoring
Description
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
This is a local change so can be tested by running
make run
and visiting http://localhost:8000I'll be making some follow up changes, so I'll add some docs while there.
Reviewer Checklist