Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgAdmin to docker compose for nice local admin UI #255

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Conversation

jamesgorrie
Copy link
Contributor

@jamesgorrie jamesgorrie commented Nov 26, 2024

Description

  • adds pgAdmin to docker compose to give us a nice UI into the DB
    Screenshot 2024-11-26 at 17 38 36
  • couple of yamllint fixes

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Remove legacy code
  • Dependency update

How Has This Been Tested?

This is a local change so can be tested by running make run and visiting http://localhost:8000

I'll be making some follow up changes, so I'll add some docs while there.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@jamesgorrie jamesgorrie requested a review from a team as a code owner November 26, 2024 17:42
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality checks are failing but otherwise happy -- following up from our chat just now in the office I think we might benefit from starting to write our own dockerfiles and store them in ECR -- as I imagine this might be reusable between repos :) Nice work!

Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we probably want to fix the conflicting lint rules going forward though rather than ignoring

@jamesgorrie jamesgorrie enabled auto-merge (squash) December 3, 2024 16:41
@jamesgorrie jamesgorrie merged commit 91b22f5 into main Dec 3, 2024
7 checks passed
@jamesgorrie jamesgorrie deleted the add-pgadmin branch December 3, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants