Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sql linting using SQLFluff #417

Merged
merged 23 commits into from
Nov 28, 2024
Merged

Add sql linting using SQLFluff #417

merged 23 commits into from
Nov 28, 2024

Conversation

katybaulch
Copy link
Contributor

Description

Add sql linting using SQLFluff

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested a review from a team as a code owner November 6, 2024 11:36
@katybaulch katybaulch changed the base branch from main to feature/pdct-1661-geo-should-only-show-documents-in-allowed-corpora-from-app November 6, 2024 11:49
@katybaulch katybaulch requested review from a team as code owners November 6, 2024 11:49
@katybaulch katybaulch changed the base branch from feature/pdct-1661-geo-should-only-show-documents-in-allowed-corpora-from-app to main November 6, 2024 11:50
Copy link
Contributor

@olaughter olaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

.trunk/configs/.sqlfluff Show resolved Hide resolved
app/repository/document.py Show resolved Hide resolved
app/repository/sql/download.sql Show resolved Hide resolved
@katybaulch katybaulch merged commit 9089898 into main Nov 28, 2024
12 checks passed
@katybaulch katybaulch deleted the add-sql-linting branch November 28, 2024 14:04
Copy link
Contributor

@annaCPR annaCPR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

app/repository/download.py Show resolved Hide resolved
app/repository/sql/slug_lookup.sql Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants