From 8db303104054b833d371b66c3f96c44991a4731a Mon Sep 17 00:00:00 2001 From: Jesse Claven Date: Thu, 22 Aug 2024 16:28:39 +0100 Subject: [PATCH] ci: Remove FIXME (#26) It's now being tracked elsewhere. --- cli/text2embeddings.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/cli/text2embeddings.py b/cli/text2embeddings.py index de954dd..deedf1c 100644 --- a/cli/text2embeddings.py +++ b/cli/text2embeddings.py @@ -126,12 +126,6 @@ def run_embeddings_generation( See docstring for run_as_cli for details. """ - # FIXME: This solution assumes that we have a json document with language = en ( - # supported target language) for every document in the parser output. This isn't - # very robust. This solution also requires passing every document into the - # embeddings stage so we are declaring tasks that are immediately dropped due to - # content. Filter only to tasks that have one language and where the language is - # supported. These could either be translated or in the original language. logger.info( "Running embeddings generation...",